Issue 1763353002: Disable UpdateProcessPriority() on startup by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1763353002: Disable UpdateProcessPriority() on startup by default. (Closed)

Created:
4 years, 9 months ago by gab

Modified:
4 years, 9 months ago

Reviewers:
ncarter (slow)

CC:
fdoray+reviewluckyluke_chromium.org, gab+reviewluckyluke_chromium.org, robliao+reviewluckyluke_chromium.org

Base URL:
https://luckyluke-private.googlesource.com/src@a_3_thread_handles

Target Ref:
refs/pending/heads/a_3_thread_handles

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable UpdateProcessPriority() on startup by default. Ref https://cbug.com/560446#c22 for experiment results. BUG=579116, 560446

Patch Set 1 #

Patch Set 2 : fix test #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -19 lines)			Patch
M	chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc	View	1	1 chunk	+14 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View		1 chunk	+5 lines, -11 lines	0 comments	Download
M	content/public/common/content_features.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/content_features.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Dependent Patchsets:

Issue 1771623002 Patch 1

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

robliao

On 2016/03/06 01:51:07, gab wrote: > Nick PTAL, thanks I think you'll need to retarget ...

4 years, 9 months ago (2016-03-07 15:13:10 UTC) #3

gab

4 years, 9 months ago (2016-03-07 18:53:01 UTC) #5

On 2016/03/07 15:13:10, robliao wrote:
> On 2016/03/06 01:51:07, gab wrote:
> > Nick PTAL, thanks
> 
> I think you'll need to retarget the base URL. It's listed as
> https://luckyluke-private.googlesource.com/src@a_3_thread_handles.

Oops, good point, thanks!

(that's what happens when I work on laptop from plane and fork a branch instead
of going back to master to avoid a rebuild..!)

Can't change base URL in same CL : new CL @
https://codereview.chromium.org/1769123002/

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages