Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1763323002: Update TestExpectations, SlowTests for various passes and failures. (Closed)

Created:
4 years, 9 months ago by Dirk Pranke
Modified:
4 years, 9 months ago
Reviewers:
qyearsley, ojan
CC:
blink-reviews, bokan, chromium-reviews, ojan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update TestExpectations, SlowTests for various passes and failures. Unreviewed, expectations change. TBR=qyearsley@chromium.org BUG=243871, 310679, 321237, 331582, 404597, 412381, 441840, 463798, 490511, 491764, 501229, 501659, 510337, 542660, 570702, 582836, 583675, 584807, 587950, 591821, 592183, 592185 Committed: https://crrev.com/c975dce2934e94db8aef1dfa46a6598d6d20f769 Cr-Commit-Position: refs/heads/master@{#379482}

Patch Set 1 : merge to #379447 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -36 lines) Patch
M third_party/WebKit/LayoutTests/SlowTests View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 20 chunks +24 lines, -34 lines 1 comment Download

Messages

Total messages: 16 (8 generated)
Dirk Pranke
Quentin, this is something you could do that would be a useful way to familiarize ...
4 years, 9 months ago (2016-03-05 03:00:59 UTC) #3
Dirk Pranke
4 years, 9 months ago (2016-03-05 03:19:52 UTC) #6
ojan
bokan actually has a WIP patch for starting this https://codereview.chromium.org/1766583002. It will need followup work ...
4 years, 9 months ago (2016-03-05 05:00:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763323002/40001
4 years, 9 months ago (2016-03-06 01:30:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 9 months ago (2016-03-06 02:33:21 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c975dce2934e94db8aef1dfa46a6598d6d20f769 Cr-Commit-Position: refs/heads/master@{#379482}
4 years, 9 months ago (2016-03-06 02:34:15 UTC) #14
qyearsley
How was this CL generated? Was it done through some invocation of run-webkit-tests? On 2016/03/05 ...
4 years, 9 months ago (2016-03-08 00:29:54 UTC) #15
Dirk Pranke
4 years, 9 months ago (2016-03-08 01:51:15 UTC) #16
Message was sent while issue was closed.
On 2016/03/08 00:29:54, qyearsley wrote:
> How was this CL generated? Was it done through some invocation of
> run-webkit-tests?

This was generated by me manually running run-webkit-tests locally on three
different platforms, looking at the local failures, and updating the ones that
seemed to be happening consistently on the bots as well.

In other words, a highly manual process :(.

>
https://codereview.chromium.org/1763323002/diff/40001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/TestExpectations (right):
> 
>
https://codereview.chromium.org/1763323002/diff/40001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/TestExpectations:25: crbug.com/501229
> fast/forms/associatedFormControls-leak-nodes.html [ Failure Pass ]
> Quick question: In the TestExpectations file, does [ Failure Pass ] mean
"either
> pass or fail is expected"? Does [ Timeout Pass ] mean "either pass or timeout
is
> expected"?

Yes to both questions.

Powered by Google App Engine
This is Rietveld 408576698