components/dom_distiller/core/distilled_content_store.h - Issue 1763273002: base: Remove OwningMRUCache in favor of scoped_ptrs in MRUCache

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/core/distilled_content_store.h

Issue 1763273002: base: Remove OwningMRUCache in favor of scoped_ptrs in MRUCache (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase + fix Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/bitmap_fetcher/bitmap_fetcher_service.cc ('K') | « chrome/browser/ui/app_list/search/common/webservice_cache.cc ('k') | components/dom_distiller/core/distilled_content_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/core/distilled_content_store.h

diff --git a/components/dom_distiller/core/distilled_content_store.h b/components/dom_distiller/core/distilled_content_store.h

index e83501aa048b53f6fa58fc6d63f80275016b43d7..62bbb49eb66989ca5c65467841932e0cde1d8269 100644

--- a/components/dom_distiller/core/distilled_content_store.h

+++ b/components/dom_distiller/core/distilled_content_store.h

@@ -64,7 +64,7 @@ class InMemoryContentStore : public DistilledContentStore {

public:

explicit CacheDeletor(InMemoryContentStore* store);

~CacheDeletor();

- void operator()(const DistilledArticleProto& proto);

+ void operator()(DistilledArticleProto* proto);

private:

InMemoryContentStore* store_;

@@ -75,10 +75,9 @@ class InMemoryContentStore : public DistilledContentStore {

void EraseUrlToIdMapping(const DistilledArticleProto& proto);

- typedef base::MRUCacheBase<std::string,

- DistilledArticleProto,

- std::less<std::string>,

- InMemoryContentStore::CacheDeletor>

+ typedef base::MRUCache<std::string,

+ scoped_ptr<DistilledArticleProto, CacheDeletor>>

ContentMap;

typedef base::hash_map<std::string, std::string> UrlMap;