Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Unified Diff: ios/chrome/browser/snapshots/lru_cache_unittest.mm

Issue 1763273002: base: Remove OwningMRUCache in favor of scoped_ptrs in MRUCache (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/snapshots/lru_cache_unittest.mm
diff --git a/ios/chrome/browser/snapshots/lru_cache_unittest.mm b/ios/chrome/browser/snapshots/lru_cache_unittest.mm
index 858a5c38bfab70da2af822e468b941eb2e0f6136..ef0b920ad87b019d455f8190f4e55af5cfcb521e 100644
--- a/ios/chrome/browser/snapshots/lru_cache_unittest.mm
+++ b/ios/chrome/browser/snapshots/lru_cache_unittest.mm
@@ -6,32 +6,10 @@
#import "ios/chrome/browser/snapshots/lru_cache.h"
#include "testing/gtest/include/gtest/gtest.h"
-@interface LRUCacheTestDelegate : NSObject<LRUCacheDelegate>
-
-@property(nonatomic, retain) id<NSObject> lastEvictedObject;
-@property(nonatomic, assign) NSInteger evictedObjectsCount;
-
-@end
-
-@implementation LRUCacheTestDelegate
-
-@synthesize lastEvictedObject = _lastEvictedObject;
-@synthesize evictedObjectsCount = _evictedObjectsCount;
-
-- (void)lruCacheWillEvictObject:(id<NSObject>)obj {
- self.lastEvictedObject = obj;
- ++_evictedObjectsCount;
-}
-
-@end
-
namespace {
TEST(LRUCacheTest, Basic) {
base::scoped_nsobject<LRUCache> cache([[LRUCache alloc] initWithCacheSize:3]);
- base::scoped_nsobject<LRUCacheTestDelegate> delegate(
- [[LRUCacheTestDelegate alloc] init]);
- [cache setDelegate:delegate];
base::scoped_nsobject<NSString> value1(
[[NSString alloc] initWithString:@"Value 1"]);
@@ -51,8 +29,6 @@ TEST(LRUCacheTest, Basic) {
[cache setObject:value4 forKey:@"VALUE 4"];
EXPECT_TRUE([cache count] == 3);
- EXPECT_TRUE([delegate evictedObjectsCount] == 1);
- EXPECT_TRUE([delegate lastEvictedObject] == value1.get());
// Check LRU behaviour, the value least recently added value should have been
// evicted.

Powered by Google App Engine
This is Rietveld 408576698