Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1763233003: S390: Initial Impl of Crankshaft features (Closed)

Created:
4 years, 9 months ago by JoranSiu
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Initial Impl of Crankshaft features S390 specific implementations of crankshaft functions. R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,jyan@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com BUG= Committed: https://crrev.com/3276e1dfadf7d0ffe75b5d59a244876145a91349 Cr-Commit-Position: refs/heads/master@{#34543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1244 lines, -1683 lines) Patch
M BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/crankshaft/lithium.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/crankshaft/lithium-allocator-inl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/crankshaft/lithium-codegen.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/crankshaft/lithium-inl.h View 1 chunk +2 lines, -0 lines 0 comments Download
A + src/crankshaft/s390/lithium-codegen-s390.h View 6 chunks +9 lines, -12 lines 0 comments Download
A + src/crankshaft/s390/lithium-codegen-s390.cc View 222 chunks +1118 lines, -1229 lines 0 comments Download
A + src/crankshaft/s390/lithium-gap-resolver-s390.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + src/crankshaft/s390/lithium-gap-resolver-s390.cc View 11 chunks +23 lines, -30 lines 0 comments Download
A + src/crankshaft/s390/lithium-s390.h View 134 chunks +4 lines, -146 lines 0 comments Download
A + src/crankshaft/s390/lithium-s390.cc View 113 chunks +61 lines, -263 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763233003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763233003/1
4 years, 9 months ago (2016-03-05 04:06:35 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-05 04:26:06 UTC) #4
JoranSiu
4 years, 9 months ago (2016-03-05 04:31:59 UTC) #5
Jakob Kummerow
LGTM (rubberstamping src/crankshaft/s390/*, actually reviewed the rest).
4 years, 9 months ago (2016-03-07 08:04:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763233003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763233003/1
4 years, 9 months ago (2016-03-07 14:23:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 14:48:53 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 14:49:17 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3276e1dfadf7d0ffe75b5d59a244876145a91349
Cr-Commit-Position: refs/heads/master@{#34543}

Powered by Google App Engine
This is Rietveld 408576698