Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 1763213002: Change scripts to avoid generating things that bloat the compiled code (Closed)

Created:
4 years, 9 months ago by Alan Knight
Modified:
4 years, 9 months ago
Reviewers:
terry, Jacob
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change scripts to avoid generating things that bloat the compiled code BUG= Committed: https://github.com/dart-lang/sdk/commit/83e2e2dbb24d081693bb4c7ecd4aacbcd056b396

Patch Set 1 #

Patch Set 2 : Fix dart2js type of WorkerPerformance.now #

Patch Set 3 : Add annotation for Notification.data #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -136 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 8 chunks +36 lines, -88 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 4 chunks +14 lines, -18 lines 0 comments Download
M sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 1 chunk +65 lines, -0 lines 0 comments Download
M tools/dom/scripts/dartmetadata.py View 1 2 5 chunks +32 lines, -0 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 2 chunks +3 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_MessageEvent.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/dom/templates/html/impl/impl_ServiceWorkerMessageEvent.darttemplate View 2 chunks +8 lines, -28 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Alan Knight
Also incorporates fixes for typedefs that get missed. TBR
4 years, 9 months ago (2016-03-04 23:07:54 UTC) #2
Alan Knight
Committed patchset #3 (id:40001) manually as 83e2e2dbb24d081693bb4c7ecd4aacbcd056b396 (presubmit successful).
4 years, 9 months ago (2016-03-04 23:08:55 UTC) #4
terry
4 years, 9 months ago (2016-03-04 23:15:24 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698