third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js - Issue 1763193002: [DevTools] Fix more frontend compiler errors

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 1763193002: [DevTools] Fix more frontend compiler errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@caseq-patch

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/timeline/LayerTreeModel.js ('K') | « third_party/WebKit/Source/devtools/front_end/timeline/LayerTreeModel.js ('k') | third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js » ('j') | third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

index 404a6b609e72902129996f947b101b2ae69ce30b..fbc0d416b3dacdbca7bf543777e3b3364ce389ee 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

@@ -157,9 +157,9 @@ WebInspector.TimelineTreeView.prototype = {

_populateColumns: function(columns)

{

- columns.push({id: "self", title: WebInspector.UIString("Self Time"), width: "110px", fixedWidth: true, sortable: true});

- columns.push({id: "total", title: WebInspector.UIString("Total Time"), width: "110px", fixedWidth: true, sortable: true});

- columns.push({id: "activity", title: WebInspector.UIString("Activity"), disclosure: true, sortable: true});

+ columns.push({id: "self", title: WebInspector.UIString("Self Time"), width: "110px", fixedWidth: true, sortable: true, editable: false, longText: null, nonSelectable: false, align: null, sort: null});

lushnikov 2016/03/04 22:49:18 lets use constructor with optional parameters?

kozy 2016/03/04 23:18:50 introduced struct instead

+ columns.push({id: "total", title: WebInspector.UIString("Total Time"), width: "110px", fixedWidth: true, sortable: true, editable: false, longText: null, nonSelectable: false, align: null, sort: null});

+ columns.push({id: "activity", title: WebInspector.UIString("Activity"), disclosure: true, sortable: true, editable: false, longText: null, nonSelectable: false, align: null, sort: null});

_sortingChanged: function()

@@ -898,7 +898,7 @@ WebInspector.EventsTimelineTreeView.prototype = {

_populateColumns: function(columns)

{

- columns.push({id: "startTime", title: WebInspector.UIString("Start Time"), width: "110px", fixedWidth: true, sortable: true});

+ columns.push({id: "startTime", title: WebInspector.UIString("Start Time"), width: "110px", fixedWidth: true, sortable: true, align: null, editable: false, longText: null, nonSelectable: false, sort: null});

WebInspector.TimelineTreeView.prototype._populateColumns.call(this, columns);