Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/LayerTreeModel.js

Issue 1763193002: [DevTools] Fix more frontend compiler errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@caseq-patch
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/timeline/LayerTreeModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/LayerTreeModel.js b/third_party/WebKit/Source/devtools/front_end/timeline/LayerTreeModel.js
index a22642d052c35ff1291c4572b5c17ea9de2c9591..ee864f35f43ce20f6d8d8132613e8cd280497f55 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/LayerTreeModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/LayerTreeModel.js
@@ -265,7 +265,7 @@ WebInspector.LayerTreeBase.prototype = {
{
if (nodesMap) {
for (var entry of nodesMap)
lushnikov 2016/03/04 22:49:18 .keys()?
kozy 2016/03/04 23:18:50 Done.
- this._backendNodeIdToNode.set(entry[0], entry[1]);
+ this._backendNodeIdToNode.set(/** @type {number} */(entry[0]), /** @type {?WebInspector.DOMNode} */(entry[1]));
}
callback();
}
@@ -382,7 +382,7 @@ WebInspector.TracingLayerTree.prototype = {
_extractNodeIdsToResolve: function(nodeIdsToResolve, seenNodeIds, payload)
{
var backendNodeId = payload.owner_node;
- if (backendNodeId && !this._backendNodeIdToNode[backendNodeId])
+ if (backendNodeId && !this._backendNodeIdToNode.has(backendNodeId))
nodeIdsToResolve.add(backendNodeId);
for (var i = 0; payload.children && i < payload.children.length; ++i)
this._extractNodeIdsToResolve(nodeIdsToResolve, seenNodeIds, payload.children[i]);

Powered by Google App Engine
This is Rietveld 408576698