[DevTools] Fix more frontend compiler errors

third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotProxy.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyrightdd
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 20 matching lines @@
 /**
  * @constructor
  * @param {function(string, *)} eventHandler
  * @extends {WebInspector.Object}
  */
 WebInspector.HeapSnapshotWorkerProxy = function(eventHandler)
 {
     this._eventHandler = eventHandler;
     this._nextObjectId = 1;
     this._nextCallId = 1;
-    this._callbacks = [];
-    this._previousCallbacks = [];
+    /** @type {!Map<number, function(*)>} */
+    this._callbacks = new Map();
+    /** @type {!Map<number, boolean>} */

[lushnikov, 2016/03/04 22:49:18]

Set?!

[kozy, 2016/03/04 23:18:50]

Done.

+    this._previousCallbacks = new Map();
     this._worker = new WorkerRuntime.Worker("heap_snapshot_worker");
     this._worker.onmessage = this._messageReceived.bind(this);
 }
 
 WebInspector.HeapSnapshotWorkerProxy.prototype = {
     /**
      * @param {number} profileUid
      * @param {function(!WebInspector.HeapSnapshotProxy)} snapshotReceivedCallback
      * @return {!WebInspector.HeapSnapshotLoaderProxy}
      */
@@ skipping 13 matching lines @@
     },
 
     disposeObject: function(objectId)
     {
         this._postMessage({callId: this._nextCallId++, disposition: "dispose", objectId: objectId});
     },
 
     evaluateForTest: function(script, callback)
     {
         var callId = this._nextCallId++;
-        this._callbacks[callId] = callback;
+        this._callbacks.set(callId, callback);
         this._postMessage({callId: callId, disposition: "evaluateForTest", source: script});
     },
 
     /**
      * @param {?function(...?)} callback
      * @param {string} objectId
      * @param {string} methodName
      * @param {function(new:T, ...?)} proxyConstructor
      * @return {?Object}
      * @template T
      */
     callFactoryMethod: function(callback, objectId, methodName, proxyConstructor)
     {
         var callId = this._nextCallId++;
         var methodArguments = Array.prototype.slice.call(arguments, 4);
         var newObjectId = this._nextObjectId++;
 
         /**
          * @this {WebInspector.HeapSnapshotWorkerProxy}
          */
         function wrapCallback(remoteResult)
         {
             callback(remoteResult ? new proxyConstructor(this, newObjectId) : null);
         }
 
         if (callback) {
-            this._callbacks[callId] = wrapCallback.bind(this);
+            this._callbacks.set(callId, wrapCallback.bind(this));
             this._postMessage({callId: callId, disposition: "factory", objectId: objectId, methodName: methodName, methodArguments: methodArguments, newObjectId: newObjectId});
             return null;
         } else {
             this._postMessage({callId: callId, disposition: "factory", objectId: objectId, methodName: methodName, methodArguments: methodArguments, newObjectId: newObjectId});
             return new proxyConstructor(this, newObjectId);
         }
     },
 
     /**
      * @param {function(*)} callback
      * @param {string} objectId
      * @param {string} methodName
      */
     callMethod: function(callback, objectId, methodName)
     {
         var callId = this._nextCallId++;
         var methodArguments = Array.prototype.slice.call(arguments, 3);
         if (callback)
-            this._callbacks[callId] = callback;
+            this._callbacks.set(callId, callback);
         this._postMessage({callId: callId, disposition: "method", objectId: objectId, methodName: methodName, methodArguments: methodArguments});
     },
 
     startCheckingForLongRunningCalls: function()
     {
         if (this._interval)
             return;
         this._checkLongRunningCalls();
         this._interval = setInterval(this._checkLongRunningCalls.bind(this), 300);
     },
 
     _checkLongRunningCalls: function()
     {
-        for (var callId in this._previousCallbacks)
-            if (!(callId in this._callbacks))
-                delete this._previousCallbacks[callId];
-        var hasLongRunningCalls = false;
-        for (callId in this._previousCallbacks) {
-            hasLongRunningCalls = true;
-            break;
-        }
+        for (var callId of this._previousCallbacks.keysArray())
+            if (!this._callbacks.has(callId))
+                this._previousCallbacks.delete(callId);
+        var hasLongRunningCalls = this._previousCallbacks.size;

[lushnikov, 2016/03/04 22:49:18]

!!

[kozy, 2016/03/04 23:18:50]

Done.

         this.dispatchEventToListeners("wait", hasLongRunningCalls);
-        for (callId in this._callbacks)
-            this._previousCallbacks[callId] = true;
+        for (var callId of this._callbacks.keysArray())
+            this._previousCallbacks.set(callId, true);
     },
 
     /**
      * @param {!MessageEvent} event
      */
     _messageReceived: function(event)
     {
         var data = event.data;
         if (data.eventName) {
             if (this._eventHandler)
                 this._eventHandler(data.eventName, data.data);
             return;
         }
         if (data.error) {
             if (data.errorMethodName)
                 WebInspector.console.error(WebInspector.UIString("An error occurred when a call to method '%s' was requested", data.errorMethodName));
             WebInspector.console.error(data["errorCallStack"]);
-            delete this._callbacks[data.callId];
+            this._callbacks.delete(data.callId);
             return;
         }
-        if (!this._callbacks[data.callId])
+        if (!this._callbacks.has(data.callId))
             return;
-        var callback = this._callbacks[data.callId];
-        delete this._callbacks[data.callId];
+        var callback = this._callbacks.get(data.callId);
+        this._callbacks.delete(data.callId);
         callback(data.result);
     },
 
     _postMessage: function(message)
     {
         this._worker.postMessage(message);
     },
 
     __proto__: WebInspector.Object.prototype
 }
@@ skipping 391 matching lines @@
      * @param {!WebInspector.HeapSnapshotCommon.ComparatorConfig} comparator
      * @return {!Promise<?>}
      */
     sortAndRewind: function(comparator)
     {
         return this._callMethodPromise("sortAndRewind", comparator);
     },
 
     __proto__: WebInspector.HeapSnapshotProxyObject.prototype
 }