[DevTools] Fix more frontend compiler errors

[DevTools] Fix more frontend compiler errors

BUG=591865
R=lushnikov@chromium.org

Committed: https://crrev.com/9c6677f6d346364b23581302dbb3a2d3905bf873
Cr-Commit-Position: refs/heads/master@{#379420}

[kozy, 2016-03-04 22:07:43]

ptal

[lushnikov, 2016-03-04 22:49:18]

lgtm

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js
(right):

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js:886:
/** @typedef {{ time: (number|undefined), endTime: number, screenshots:
!Array.<string>}} */
looks like "time" is never used

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotProxy.js
(right):

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotProxy.js:43:
/** @type {!Map<number, boolean>} */
Set?!

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotProxy.js:141:
var hasLongRunningCalls = this._previousCallbacks.size;
!!

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js
(right):

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js:56:
/** @type {!Array<?ESTree.Node>} */
revert

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js:85:
identifiers.push(node.id);
cast to !Estree.node

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/LayerTreeModel.js
(right):

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/LayerTreeModel.js:267: for
(var entry of nodesMap)
.keys()?

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
(right):

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js:160:
columns.push({id: "self", title: WebInspector.UIString("Self Time"), width:
"110px", fixedWidth: true, sortable: true, editable: false, longText: null,
nonSelectable: false, align: null, sort: null});
lets use constructor with optional parameters?

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js (right):

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js:163:
WebInspector.DataGrid.ColumnDescriptor;
constructor?

[kozy, 2016-03-04 23:18:50]

all done, ptal

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js
(right):

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js:886:
/** @typedef {{ time: (number|undefined), endTime: number, screenshots:
!Array.<string>}} */
On 2016/03/04 22:49:18, lushnikov wrote:
> looks like "time" is never used

Done.

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotProxy.js
(right):

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotProxy.js:43:
/** @type {!Map<number, boolean>} */
On 2016/03/04 22:49:18, lushnikov wrote:
> Set?!

Done.

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotProxy.js:141:
var hasLongRunningCalls = this._previousCallbacks.size;
On 2016/03/04 22:49:18, lushnikov wrote:
> !!

Done.

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js
(right):

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js:56:
/** @type {!Array<?ESTree.Node>} */
On 2016/03/04 22:49:18, lushnikov wrote:
> revert

Done.

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js:85:
identifiers.push(node.id);
On 2016/03/04 22:49:18, lushnikov wrote:
> cast to !Estree.node

Done.

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/LayerTreeModel.js
(right):

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/LayerTreeModel.js:267: for
(var entry of nodesMap)
On 2016/03/04 22:49:18, lushnikov wrote:
> .keys()?

Done.

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
(right):

https://codereview.chromium.org/1763193002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js:160:
columns.push({id: "self", title: WebInspector.UIString("Self Time"), width:
"110px", fixedWidth: true, sortable: true, editable: false, longText: null,
nonSelectable: false, align: null, sort: null});
On 2016/03/04 22:49:18, lushnikov wrote:
> lets use constructor with optional parameters?

introduced struct instead

[kozy, 2016-03-04 23:19:03]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-03-04 23:19:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/1763193002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-03-04 23:19:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1763193002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1763193002/20001

[commit-bot: I haz the power, 2016-03-05 00:58:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-05 01:00:07]

Description was changed from

==========
[DevTools] Fix more frontend compiler errors

BUG=591865
R=lushnikov@chromium.org
==========

to

==========
[DevTools] Fix more frontend compiler errors

BUG=591865
R=lushnikov@chromium.org

Committed: https://crrev.com/9c6677f6d346364b23581302dbb3a2d3905bf873
Cr-Commit-Position: refs/heads/master@{#379420}
==========

[commit-bot: I haz the power, 2016-03-05 01:00:08]

Patchset 2 (id:??) landed as
https://crrev.com/9c6677f6d346364b23581302dbb3a2d3905bf873
Cr-Commit-Position: refs/heads/master@{#379420}