New SearchEngine implementation - references only.

New SearchEngine implementation - references only.

And only for the elements for which we have information in the index.
References to other kinds of elements - local variables, parameters,
etc can be implemented using AST visitors. To be implemented in next CLs.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/aa7bea0d6a44013d4edd224cf4bd153f80268e55

[Brian Wilkerson, 2016-03-04 19:34:44]

LGTM

https://codereview.chromium.org/1763133002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart
(right):

https://codereview.chromium.org/1763133002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart:55:
return _searchReferences(element);
Are the current calls to _searchReferences going to remain unchanged? If so,
would it be better to or together the conditions:

  ElementKind kind = element.kind;
  if (kind == ElementKind.CLASS || kind == ElementKind.COMPILATION_UNIT || ...)
{
    return _searchReferences(element);
  } else if (...

[scheglov, 2016-03-04 20:08:08]

Description was changed from

==========
New SearchEngine implementation - references only.

And only for the elements for which we have information in the index.
References to other kinds of elements - local variables, parameters,
etc can be implemented using AST visitors. To be implemented in next CLs.

R=brianwilkerson@google.com
BUG=
==========

to

==========
New SearchEngine implementation - references only.

And only for the elements for which we have information in the index.
References to other kinds of elements - local variables, parameters,
etc can be implemented using AST visitors. To be implemented in next CLs.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/aa7bea0d6a44013d4edd224cf4bd153f80268e55
==========

[scheglov, 2016-03-04 20:08:09]

Committed patchset #1 (id:1) manually as
aa7bea0d6a44013d4edd224cf4bd153f80268e55 (presubmit successful).