Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1676)

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 1763123002: [BackgroundSync] Remove BackgroundSyncRegistrationHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments from PS7 Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.cc
diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc
index 28fdecb4e6fa025c60a09158286b414f4a01211b..3c3e38451fc5420b442e7bc78d834f83a5351b8c 100644
--- a/content/renderer/service_worker/service_worker_context_client.cc
+++ b/content/renderer/service_worker/service_worker_context_client.cc
@@ -691,14 +691,18 @@ void ServiceWorkerContextClient::registerForeignFetchScopes(
}
void ServiceWorkerContextClient::DispatchSyncEvent(
- const blink::WebSyncRegistration& registration,
+ const std::string& tag,
blink::WebServiceWorkerContextProxy::LastChanceOption last_chance,
const SyncCallback& callback) {
TRACE_EVENT0("ServiceWorker",
"ServiceWorkerContextClient::DispatchSyncEvent");
int request_id =
context_->sync_event_callbacks.Add(new SyncCallback(callback));
- proxy_->dispatchSyncEvent(request_id, registration, last_chance);
+
+ // TODO(jkarlin): Make this blink::WebString::FromUTF8Lenient once
+ // https://crrev.com/1768063002/ lands.
+ proxy_->dispatchSyncEvent(request_id, blink::WebString::fromUTF8(tag),
+ last_chance);
}
void ServiceWorkerContextClient::Send(IPC::Message* message) {

Powered by Google App Engine
This is Rietveld 408576698