content/renderer/background_sync/background_sync_client_impl.h - Issue 1763123002: [BackgroundSync] Remove BackgroundSyncRegistrationHandle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/background_sync/background_sync_client_impl.h

Issue 1763123002: [BackgroundSync] Remove BackgroundSyncRegistrationHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments from PS7 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/test/background_sync_test_util.cc ('k') | content/renderer/background_sync/background_sync_client_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/background_sync/background_sync_client_impl.h

diff --git a/content/renderer/background_sync/background_sync_client_impl.h b/content/renderer/background_sync/background_sync_client_impl.h

index 3b209b343e01f2fdfdcf5063120c87071977f7dc..c18ccf1e844d0acfaa54d208878cc3845dfc51d7 100644

--- a/content/renderer/background_sync/background_sync_client_impl.h

+++ b/content/renderer/background_sync/background_sync_client_impl.h

@@ -31,20 +31,12 @@ class CONTENT_EXPORT BackgroundSyncClientImpl

mojo::InterfaceRequest<BackgroundSyncServiceClient> request);

// BackgroundSyncServiceClient methods:

- void Sync(int64_t handle_id,

+ void Sync(const mojo::String& tag,

content::BackgroundSyncEventLastChance last_chance,

const SyncCallback& callback) override;

- void SyncDidGetRegistration(

- int64_t callback_id,

- content::BackgroundSyncEventLastChance last_chance,

- BackgroundSyncError error,

- SyncRegistrationPtr registration);

mojo::StrongBinding<BackgroundSyncServiceClient> binding_;

- int64_t callback_seq_num_;

- std::map<int64_t, SyncCallback> sync_callbacks_;

DISALLOW_COPY_AND_ASSIGN(BackgroundSyncClientImpl);

};