content/child/background_sync/background_sync_type_converters.cc - Issue 1763123002: [BackgroundSync] Remove BackgroundSyncRegistrationHandle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/background_sync/background_sync_type_converters.cc

Issue 1763123002: [BackgroundSync] Remove BackgroundSyncRegistrationHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments from PS7 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/background_sync/background_sync_provider.cc ('k') | content/child/background_sync/background_sync_type_converters_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/background_sync/background_sync_type_converters.cc

diff --git a/content/child/background_sync/background_sync_type_converters.cc b/content/child/background_sync/background_sync_type_converters.cc

index 61088f8e909c7fb6a24e745257eeacf6182b87df..607844a4c911f37e8c91698c8fa5dbfd029b749d 100644

--- a/content/child/background_sync/background_sync_type_converters.cc

+++ b/content/child/background_sync/background_sync_type_converters.cc

@@ -51,7 +51,7 @@ scoped_ptr<blink::WebSyncRegistration> TypeConverter<

const content::SyncRegistrationPtr& input) {

scoped_ptr<blink::WebSyncRegistration> result(

new blink::WebSyncRegistration());

- result->id = input->handle_id;

+ result->id = input->id;

result->tag = blink::WebString::fromUTF8(input->tag);

result->networkState =

ConvertTo<blink::WebSyncRegistration::NetworkState>(input->network_state);

@@ -65,7 +65,7 @@ content::SyncRegistrationPtr TypeConverter<

const blink::WebSyncRegistration& input) {

content::SyncRegistrationPtr result(

content::SyncRegistration::New());

- result->handle_id = input.id;

+ result->id = input.id;

result->tag = input.tag.utf8();

result->network_state =

ConvertTo<content::BackgroundSyncNetworkState>(input.networkState);