content/child/background_sync/background_sync_provider.h - Issue 1763123002: [BackgroundSync] Remove BackgroundSyncRegistrationHandle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/background_sync/background_sync_provider.h

Issue 1763123002: [BackgroundSync] Remove BackgroundSyncRegistrationHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments from PS7 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/background_sync/background_sync_service_impl.cc ('k') | content/child/background_sync/background_sync_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/background_sync/background_sync_provider.h

diff --git a/content/child/background_sync/background_sync_provider.h b/content/child/background_sync/background_sync_provider.h

index cbcd9d71decdfcf9231b40785930bbdc6b9b9e0f..cdba5ce0cb6788d2b7afc8d63aaaf3bc73a4fa71 100644

--- a/content/child/background_sync/background_sync_provider.h

+++ b/content/child/background_sync/background_sync_provider.h

@@ -53,13 +53,6 @@ class BackgroundSyncProvider : public blink::WebSyncProvider,

void getRegistrations(

blink::WebServiceWorkerRegistration* service_worker_registration,

blink::WebSyncGetRegistrationsCallbacks* callbacks) override;

- // TODO(jkarlin): Rename to releaseRegistrationHandle.

- void releaseRegistration(int64_t handle_id) override;

- void DuplicateRegistrationHandle(

- int64_t handle_id,

- const BackgroundSyncService::DuplicateRegistrationHandleCallback&

- callback);

// WorkerThread::Observer implementation.

void WillStopCurrentWorkerThread() override;