Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: content/browser/background_sync/background_sync_service_impl.h

Issue 1763123002: [BackgroundSync] Remove BackgroundSyncRegistrationHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments from PS7 Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_sync/background_sync_service_impl.h
diff --git a/content/browser/background_sync/background_sync_service_impl.h b/content/browser/background_sync/background_sync_service_impl.h
index 0466e994f7f104bab67714c839b64624dc87a6b2..27a302ba66dd2c5f0d99c7600476dd53cd060e14 100644
--- a/content/browser/background_sync/background_sync_service_impl.h
+++ b/content/browser/background_sync/background_sync_service_impl.h
@@ -38,19 +38,14 @@ class CONTENT_EXPORT BackgroundSyncServiceImpl
const RegisterCallback& callback) override;
void GetRegistrations(int64_t sw_registration_id,
const GetRegistrationsCallback& callback) override;
- void DuplicateRegistrationHandle(
- BackgroundSyncRegistrationHandle::HandleId handle_id,
- const DuplicateRegistrationHandleCallback& callback) override;
- void ReleaseRegistration(
- BackgroundSyncRegistrationHandle::HandleId handle_id) override;
void OnRegisterResult(const RegisterCallback& callback,
BackgroundSyncStatus status,
- scoped_ptr<BackgroundSyncRegistrationHandle> result);
+ scoped_ptr<BackgroundSyncRegistration> result);
void OnGetRegistrationsResult(
const GetRegistrationsCallback& callback,
BackgroundSyncStatus status,
- scoped_ptr<ScopedVector<BackgroundSyncRegistrationHandle>> result);
+ scoped_ptr<ScopedVector<BackgroundSyncRegistration>> result);
// Called when an error is detected on binding_.
void OnConnectionError();
@@ -60,11 +55,6 @@ class CONTENT_EXPORT BackgroundSyncServiceImpl
mojo::Binding<BackgroundSyncService> binding_;
- // The registrations that the client might reference.
- IDMap<BackgroundSyncRegistrationHandle,
- IDMapOwnPointer,
- BackgroundSyncRegistrationHandle::HandleId> active_handles_;
-
base::WeakPtrFactory<BackgroundSyncServiceImpl> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(BackgroundSyncServiceImpl);

Powered by Google App Engine
This is Rietveld 408576698