content/browser/background_sync/background_sync_registration.h - Issue 1763123002: [BackgroundSync] Remove BackgroundSyncRegistrationHandle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/background_sync/background_sync_registration.h

Issue 1763123002: [BackgroundSync] Remove BackgroundSyncRegistrationHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments from PS7 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/background_sync/background_sync_manager_unittest.cc ('k') | content/browser/background_sync/background_sync_registration.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/background_sync/background_sync_registration.h

diff --git a/content/browser/background_sync/background_sync_registration.h b/content/browser/background_sync/background_sync_registration.h

index bcfe375d875390ed2618f4ec6647253652238dfe..d51edaf75aa924bb753317038a0861ea191d003b 100644

--- a/content/browser/background_sync/background_sync_registration.h

+++ b/content/browser/background_sync/background_sync_registration.h

@@ -27,8 +27,11 @@ class CONTENT_EXPORT BackgroundSyncRegistration {

static const RegistrationId kInitialId;

- BackgroundSyncRegistration();

- ~BackgroundSyncRegistration();

+ BackgroundSyncRegistration() = default;

+ BackgroundSyncRegistration(const BackgroundSyncRegistration& other) = default;

+ BackgroundSyncRegistration& operator=(

+ const BackgroundSyncRegistration& other) = default;

+ ~BackgroundSyncRegistration() = default;

bool Equals(const BackgroundSyncRegistration& other) const;

bool IsValid() const;

@@ -57,9 +60,6 @@ class CONTENT_EXPORT BackgroundSyncRegistration {

BackgroundSyncState sync_state_ = BackgroundSyncState::PENDING;

int num_attempts_ = 0;

base::Time delay_until_;

- DISALLOW_COPY_AND_ASSIGN(BackgroundSyncRegistration);

};

} // namespace content