third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h - Issue 1763123002: [BackgroundSync] Remove BackgroundSyncRegistrationHandle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

Issue 1763123002: [BackgroundSync] Remove BackgroundSyncRegistrationHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments from PS6 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/background_sync/background_sync_manager.cc ('K') | « content/renderer/service_worker/service_worker_context_client.cc ('k') | third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp » ('j') | third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

index e1fd8162b962cbe46518887023f688877e72df00..26ad937593d5ccce5594016eaf60f04efc15c0c3 100644

--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

@@ -85,7 +85,7 @@ public:

void dispatchNotificationCloseEvent(int, int64_t notificationID, const WebNotificationData&) override;

void dispatchPushEvent(int, const WebString& data) override;

void dispatchServicePortConnectEvent(WebServicePortConnectEventCallbacks*, const WebURL& targetURL, const WebString& origin, WebServicePortID) override;

- void dispatchSyncEvent(int, const WebSyncRegistration&, LastChanceOption) override;

+ void dispatchSyncEvent(int, const WebString& tag, LastChanceOption) override;

// WorkerReportingProxy overrides:

void reportException(const String& errorMessage, int lineNumber, int columnNumber, const String& sourceURL, int exceptionId) override;