[BackgroundSync] Remove BackgroundSyncRegistrationHandle

content/browser/background_sync/background_sync_registration.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_BACKGROUND_SYNC_BACKGROUND_SYNC_REGISTRATION_H_
 #define CONTENT_BROWSER_BACKGROUND_SYNC_BACKGROUND_SYNC_REGISTRATION_H_
 
 #include <stdint.h>
 
 #include <list>
@@ skipping 10 matching lines @@
 
 namespace content {
 
 class CONTENT_EXPORT BackgroundSyncRegistration {
  public:
   using RegistrationId = int64_t;
 
   static const RegistrationId kInitialId;
 
   BackgroundSyncRegistration();
+  BackgroundSyncRegistration(const BackgroundSyncRegistration& other) = default;

[iclelland, 2016/03/08 16:48:14]

Style question -- these are defined default inline here, while the constructor
and destructor are defined in the .cc file -- is there any reason behind that?
(I ask because I had to go look at the constructor to make sure it was trivial)

[jkarlin, 2016/03/08 19:37:36]

Thanks. They're supposed to be in the header.

+  BackgroundSyncRegistration& operator=(
+      const BackgroundSyncRegistration& other) = default;
+
   ~BackgroundSyncRegistration();
 
   bool Equals(const BackgroundSyncRegistration& other) const;
   bool IsValid() const;
   bool IsFiring() const;
 
   const BackgroundSyncRegistrationOptions* options() const { return &options_; }
   BackgroundSyncRegistrationOptions* options() { return &options_; }
 
   RegistrationId id() const { return id_; }
   void set_id(RegistrationId id) { id_ = id; }
 
   BackgroundSyncState sync_state() const { return sync_state_; }
   void set_sync_state(BackgroundSyncState state) { sync_state_ = state; }
 
   int num_attempts() const { return num_attempts_; }
   void set_num_attempts(int num_attempts) { num_attempts_ = num_attempts; }
 
   base::Time delay_until() const { return delay_until_; }
   void set_delay_until(base::Time delay_until) { delay_until_ = delay_until; }
 
  private:
   static const RegistrationId kInvalidRegistrationId;
 
   BackgroundSyncRegistrationOptions options_;
   RegistrationId id_ = kInvalidRegistrationId;
   BackgroundSyncState sync_state_ = BackgroundSyncState::PENDING;
   int num_attempts_ = 0;
   base::Time delay_until_;
-
-
-  DISALLOW_COPY_AND_ASSIGN(BackgroundSyncRegistration);
 };
 
 }  // namespace content
 
 namespace mojo {
 
 template <>
 struct CONTENT_EXPORT
     TypeConverter<scoped_ptr<content::BackgroundSyncRegistration>,
                   content::SyncRegistrationPtr> {
   static scoped_ptr<content::BackgroundSyncRegistration> Convert(
       const content::SyncRegistrationPtr& input);
 };
 
 template <>
 struct CONTENT_EXPORT TypeConverter<content::SyncRegistrationPtr,
                                     content::BackgroundSyncRegistration> {
   static content::SyncRegistrationPtr Convert(
       const content::BackgroundSyncRegistration& input);
 };
 
 }  // namespace
 
 #endif  // CONTENT_BROWSER_BACKGROUND_SYNC_BACKGROUND_SYNC_REGISTRATION_H_