Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: content/shell/app/shell_main_delegate_mac.mm

Issue 1763113002: Move layout-test-specific switches from shell_switches to layout_test_switches.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-line-box-and-debug-from-flags-struct
Patch Set: Fix accidental condition reversal in Shell::ToggleFullscreenModeForTab. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/shell/app/shell_main_delegate_mac.h" 5 #include "content/shell/app/shell_main_delegate_mac.h"
6 6
7 #include <unistd.h> 7 #include <unistd.h>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 10 matching lines...) Expand all
21 // Exit early if this isn't a browser process. 21 // Exit early if this isn't a browser process.
22 if (base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kProcessType)) 22 if (base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kProcessType))
23 return; 23 return;
24 24
25 NSString* const kHighResolutionCapable = @"NSHighResolutionCapable"; 25 NSString* const kHighResolutionCapable = @"NSHighResolutionCapable";
26 base::FilePath info_plist = GetInfoPlistPath(); 26 base::FilePath info_plist = GetInfoPlistPath();
27 base::scoped_nsobject<NSMutableDictionary> info_dict( 27 base::scoped_nsobject<NSMutableDictionary> info_dict(
28 [[NSMutableDictionary alloc] 28 [[NSMutableDictionary alloc]
29 initWithContentsOfFile:base::mac::FilePathToNSString(info_plist)]); 29 initWithContentsOfFile:base::mac::FilePathToNSString(info_plist)]);
30 30
31 bool running_layout_tests = base::CommandLine::ForCurrentProcess()->HasSwitch( 31 bool running_layout_tests = switches::IsRunLayoutTestSwitchPresent();
32 switches::kRunLayoutTest);
33 bool not_high_resolution_capable = 32 bool not_high_resolution_capable =
34 [info_dict objectForKey:kHighResolutionCapable] && 33 [info_dict objectForKey:kHighResolutionCapable] &&
35 [[info_dict objectForKey:kHighResolutionCapable] isEqualToNumber:@(NO)]; 34 [[info_dict objectForKey:kHighResolutionCapable] isEqualToNumber:@(NO)];
36 if (running_layout_tests == not_high_resolution_capable) 35 if (running_layout_tests == not_high_resolution_capable)
37 return; 36 return;
38 37
39 // We need to update our Info.plist before we can continue. 38 // We need to update our Info.plist before we can continue.
40 [info_dict setObject:@(!running_layout_tests) forKey:kHighResolutionCapable]; 39 [info_dict setObject:@(!running_layout_tests) forKey:kHighResolutionCapable];
41 CHECK([info_dict writeToFile:base::mac::FilePathToNSString(info_plist) 40 CHECK([info_dict writeToFile:base::mac::FilePathToNSString(info_plist)
42 atomically:YES]); 41 atomically:YES]);
43 42
44 const base::CommandLine::StringVector& original_argv = 43 const base::CommandLine::StringVector& original_argv =
45 base::CommandLine::ForCurrentProcess()->argv(); 44 base::CommandLine::ForCurrentProcess()->argv();
46 char** argv = new char*[original_argv.size() + 1]; 45 char** argv = new char*[original_argv.size() + 1];
47 for (unsigned i = 0; i < original_argv.size(); ++i) 46 for (unsigned i = 0; i < original_argv.size(); ++i)
48 argv[i] = const_cast<char*>(original_argv.at(i).c_str()); 47 argv[i] = const_cast<char*>(original_argv.at(i).c_str());
49 argv[original_argv.size()] = NULL; 48 argv[original_argv.size()] = NULL;
50 49
51 CHECK(execvp(argv[0], argv)); 50 CHECK(execvp(argv[0], argv));
52 } 51 }
53 52
54 } // namespace content 53 } // namespace content
OLDNEW
« no previous file with comments | « content/shell/app/shell_main_delegate.cc ('k') | content/shell/browser/layout_test/blink_test_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698