content/shell/common/shell_switches.h - Issue 1763113002: Move layout-test-specific switches from shell_switches to layout_test_switches.h

Side by Side Diff: content/shell/common/shell_switches.h

Issue 1763113002: Move layout-test-specific switches from shell_switches to layout_test_switches.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-line-box-and-debug-from-flags-struct

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/shell/browser/layout_test/layout_test_browser_main.cc ('K') | « content/shell/common/shell_content_client.cc ('k') | content/shell/common/shell_switches.cc » ('j') | content/shell/renderer/shell_render_view_observer.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Defines all the "content_shell" command-line switches.	5 // Defines all the "content_shell" command-line switches.

6	6

7 #ifndef CONTENT_SHELL_COMMON_SHELL_SWITCHES_H_	7 #ifndef CONTENT_SHELL_COMMON_SHELL_SWITCHES_H_

8 #define CONTENT_SHELL_COMMON_SHELL_SWITCHES_H_	8 #define CONTENT_SHELL_COMMON_SHELL_SWITCHES_H_

9	9

10 #include <string>	10 #include <string>

11 #include <vector>	11 #include <vector>

12	12

13 namespace switches {	13 namespace switches {

14	14

15 extern const char kAllowExternalPages[];
Łukasz Anforowicz 2016/03/04 17:59:37 I tried to see where the switches are used and mov I tried to see where the switches are used and moved ones mostly used only under layout_tests. OTOH, some of them seemed rather generic (i.e. kEnableAccelerated2DCanvas)... hmmm...
16 extern const char kCheckLayoutTestSysDeps[];

17 extern const char kContentBrowserTest[];	15 extern const char kContentBrowserTest[];

18 extern const char kContentShellDataPath[];	16 extern const char kContentShellDataPath[];

19 extern const char kCrashDumpsDir[];	17 extern const char kCrashDumpsDir[];

20 extern const char kCrashOnFailure[];

21 extern const char kEnableAccelerated2DCanvas[];

22 extern const char kEnableFontAntialiasing[];

23 extern const char kAlwaysUseComplexText[];

24 extern const char kEnableLeakDetection[];

25 extern const char kEncodeBinary[];

26 extern const char kExposeInternalsForTesting[];

27 extern const char kIsolateSitesForTesting[];	18 extern const char kIsolateSitesForTesting[];

28 extern const char kRegisterFontFiles[];	19 extern const char kRegisterFontFiles[];

29 extern const char kRunLayoutTest[];

30 extern const char kStableReleaseMode[];

31 extern const char kContentShellHostWindowSize[];	20 extern const char kContentShellHostWindowSize[];

32	21

33 // Returns list of extra font files to be made accessible to the renderer.	22 // Returns list of extra font files to be made accessible to the renderer.

34 std::vector<std::string> GetSideloadFontFiles();	23 std::vector<std::string> GetSideloadFontFiles();

35	24

	25 // Tells if content shell is running layout tests.

	26 // TODO(lukasza): The function below somewhat violates the layering (by

	27 // enabling shell -> layout_tests dependency) but at least narrows the extent of

	28 // the dependency to a single switch...

	29 bool IsRunLayoutTestSwitchPresent();
	Łukasz Anforowicz 2016/03/04 17:51:15 This is a bit of a weird method, but I think it is This is a bit of a weird method, but I think it is worth introducing it, because otherwise we would still need to drag in the whole layout_test_switches.h into content/shell/browser/shell.cc, content/shell/common/shell_content_client.cc. I guess one can look at this as 1 out of 3 remaining shell -> layout_test dependencies (the include is hidden in shell_switches.cc).
	30

36 } // namespace switches	31 } // namespace switches

37	32

38 #endif // CONTENT_SHELL_COMMON_SHELL_SWITCHES_H_	33 #endif // CONTENT_SHELL_COMMON_SHELL_SWITCHES_H_

OLD	NEW