|
|
Description[Interpreter] Updated mjsunit.status
Updated mjsunit.status.
BUG=v8:4280
LOG=N
Committed: https://crrev.com/b455e2b2a0df51c3d91372293c3bb5f77f01b467
Cr-Commit-Position: refs/heads/master@{#34545}
Patch Set 1 #Patch Set 2 : updated mjsunit.status #Patch Set 3 : updated mjsunit.status #
Total comments: 13
Patch Set 4 : Fixes comments #Patch Set 5 : rebased the patch #Patch Set 6 : Removed a comment not needed anymore. #Messages
Total messages: 34 (16 generated)
The CQ bit was checked by mythria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763053002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/14769)
The CQ bit was checked by mythria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763053002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/14777)
The CQ bit was checked by mythria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763053002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763053002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Exceeded global retry quota
mythria@chromium.org changed reviewers: + rmcilroy@chromium.org
PTAL. Thanks, Mythri https://codereview.chromium.org/1763053002/diff/40001/test/mjsunit/mjsunit.st... File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/1763053002/diff/40001/test/mjsunit/mjsunit.st... test/mjsunit/mjsunit.status:914: 'compiler/osr-two': [PASS, ['mode == debug', SKIP]], These two tests pass in release mode, but I am not sure we should enable them. They actually test for osr, but since we don't have them they test nothing. Its a big loop so takes a lot of time. https://codereview.chromium.org/1763053002/diff/40001/test/mjsunit/mjsunit.st... test/mjsunit/mjsunit.status:915: 'regress/regress-1257': [SKIP], This test is flaky. It pass locally for me always. but times out on bots sometimes.
Thanks for doing a pass on these. LGTM once the bots are all happy and comments addressed. https://codereview.chromium.org/1763053002/diff/40001/test/mjsunit/mjsunit.st... File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/1763053002/diff/40001/test/mjsunit/mjsunit.st... test/mjsunit/mjsunit.status:825: # Related to Debugger. Goes into a loop in function: # TODO(yangguo/rmcilroy,4690): https://codereview.chromium.org/1763053002/diff/40001/test/mjsunit/mjsunit.st... test/mjsunit/mjsunit.status:892: 'debug-liveedit-2': [FAIL], Move to the "assertion failures in LiveEdit tests" section. https://codereview.chromium.org/1763053002/diff/40001/test/mjsunit/mjsunit.st... test/mjsunit/mjsunit.status:907: # There is a global flag to skip this, do we need it here? Nope, just remove it if it from here skipped globally. https://codereview.chromium.org/1763053002/diff/40001/test/mjsunit/mjsunit.st... test/mjsunit/mjsunit.status:914: 'compiler/osr-two': [PASS, ['mode == debug', SKIP]], On 2016/03/04 17:31:41, mythria wrote: > These two tests pass in release mode, but I am not sure we should enable them. > They actually test for osr, but since we don't have them they test nothing. Its > a big loop so takes a lot of time. If this works, PASS on release and SKIP on debug sounds fine to me. https://codereview.chromium.org/1763053002/diff/40001/test/mjsunit/mjsunit.st... test/mjsunit/mjsunit.status:915: 'regress/regress-1257': [SKIP], On 2016/03/04 17:31:41, mythria wrote: > This test is flaky. It pass locally for me always. but times out on bots > sometimes. Ack, it might just be super slow, if so we can take another look once we've done some optimizing. https://codereview.chromium.org/1763053002/diff/40001/test/mjsunit/mjsunit.st... test/mjsunit/mjsunit.status:916: # There is a global flag to skip this, do we need it here? Nope, just remove it if it from here skipped globally.
Thanks, done. https://codereview.chromium.org/1763053002/diff/40001/test/mjsunit/mjsunit.st... File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/1763053002/diff/40001/test/mjsunit/mjsunit.st... test/mjsunit/mjsunit.status:825: # Related to Debugger. Goes into a loop in function: On 2016/03/05 03:11:32, rmcilroy (Slow - Traveling) wrote: > # TODO(yangguo/rmcilroy,4690): Done. https://codereview.chromium.org/1763053002/diff/40001/test/mjsunit/mjsunit.st... test/mjsunit/mjsunit.status:892: 'debug-liveedit-2': [FAIL], On 2016/03/05 03:11:32, rmcilroy (Slow - Traveling) wrote: > Move to the "assertion failures in LiveEdit tests" section. Done. https://codereview.chromium.org/1763053002/diff/40001/test/mjsunit/mjsunit.st... test/mjsunit/mjsunit.status:907: # There is a global flag to skip this, do we need it here? On 2016/03/05 03:11:32, rmcilroy (Slow - Traveling) wrote: > Nope, just remove it if it from here skipped globally. Done. https://codereview.chromium.org/1763053002/diff/40001/test/mjsunit/mjsunit.st... test/mjsunit/mjsunit.status:914: 'compiler/osr-two': [PASS, ['mode == debug', SKIP]], On 2016/03/05 03:11:32, rmcilroy (Slow - Traveling) wrote: > On 2016/03/04 17:31:41, mythria wrote: > > These two tests pass in release mode, but I am not sure we should enable them. > > They actually test for osr, but since we don't have them they test nothing. > Its > > a big loop so takes a lot of time. > > If this works, PASS on release and SKIP on debug sounds fine to me. Done. https://codereview.chromium.org/1763053002/diff/40001/test/mjsunit/mjsunit.st... test/mjsunit/mjsunit.status:916: # There is a global flag to skip this, do we need it here? On 2016/03/05 03:11:32, rmcilroy (Slow - Traveling) wrote: > Nope, just remove it if it from here skipped globally. Done.
The CQ bit was checked by mythria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763053002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763053002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)
The CQ bit was checked by mythria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763053002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763053002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mythria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763053002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763053002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mythria@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rmcilroy@chromium.org Link to the patchset: https://codereview.chromium.org/1763053002/#ps100001 (title: "Removed a comment not needed anymore.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763053002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763053002/100001
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Updated mjsunit.status Updated mjsunit.status. BUG=v8:4280 LOG=N ========== to ========== [Interpreter] Updated mjsunit.status Updated mjsunit.status. BUG=v8:4280 LOG=N Committed: https://crrev.com/b455e2b2a0df51c3d91372293c3bb5f77f01b467 Cr-Commit-Position: refs/heads/master@{#34545} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/b455e2b2a0df51c3d91372293c3bb5f77f01b467 Cr-Commit-Position: refs/heads/master@{#34545} |