Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 1763043002: Add ColorspaceConversion in ImageBitmapOptions (Closed)

Created:
4 years, 9 months ago by xidachen
Modified:
4 years, 9 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ColorspaceConversion in ImageBitmapOptions This option is specifically for createImageBitmap from a Blob or a HTMLImageElement. This CL adds support for this option, starting with Blob. Layout tests are added to ensure the correctness. BUG=592005 Committed: https://crrev.com/1e71ee33752db1b8817870cc25324ae40dbcd6d3 Cr-Commit-Position: refs/heads/master@{#381224}

Patch Set 1 #

Patch Set 2 : remove layout tests #

Patch Set 3 : colorspace conversion for all sources #

Total comments: 6

Patch Set 4 : better structure in cases #

Patch Set 5 : remove comment lines #

Patch Set 6 : rebase #

Patch Set 7 : add notprovided option #

Patch Set 8 : temporary remove newly added binary file to debug on Mac, DO NOT COMMIT THIS PS #

Patch Set 9 : add the binary file back #

Patch Set 10 : change tolerance to 13 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -43 lines) Patch
A third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/square-with-colorspin-profile.png View 1 2 8 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/tex-image-and-sub-image-image-bitmap-utils.js View 1 2 3 4 5 6 7 8 9 3 chunks +36 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-image-bitmap-from-blob.html View 1 2 3 chunks +28 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-image-bitmap-from-canvas.html View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-image-bitmap-from-image.html View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-image-bitmap-from-image-bitmap.html View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-image-bitmap-from-image-data.html View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-image-bitmap-from-video.html View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp View 1 2 3 4 5 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapOptions.idl View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 25 (14 generated)
xidachen
PTAL.
4 years, 9 months ago (2016-03-09 12:05:07 UTC) #7
Justin Novosad
https://codereview.chromium.org/1763043002/diff/40001/third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/tex-image-and-sub-image-image-bitmap-utils.js File third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/tex-image-and-sub-image-image-bitmap-utils.js (right): https://codereview.chromium.org/1763043002/diff/40001/third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/tex-image-and-sub-image-image-bitmap-utils.js#newcode102 third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/tex-image-and-sub-image-image-bitmap-utils.js:102: { sub: true }, The structure of this test ...
4 years, 9 months ago (2016-03-09 16:29:39 UTC) #8
xidachen
https://codereview.chromium.org/1763043002/diff/40001/third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/tex-image-and-sub-image-image-bitmap-utils.js File third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/tex-image-and-sub-image-image-bitmap-utils.js (right): https://codereview.chromium.org/1763043002/diff/40001/third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/tex-image-and-sub-image-image-bitmap-utils.js#newcode102 third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/tex-image-and-sub-image-image-bitmap-utils.js:102: { sub: true }, On 2016/03/09 16:29:39, Justin Novosad ...
4 years, 9 months ago (2016-03-14 13:29:42 UTC) #9
Justin Novosad
> On 2016/03/09 16:29:39, Justin Novosad wrote: > > What is the difference between colorspaceDef ...
4 years, 9 months ago (2016-03-14 15:12:51 UTC) #10
xidachen
On 2016/03/14 15:12:51, Justin Novosad wrote: > > On 2016/03/09 16:29:39, Justin Novosad wrote: > ...
4 years, 9 months ago (2016-03-14 15:32:34 UTC) #11
Justin Novosad
On 2016/03/14 15:32:34, xidachen wrote: > On 2016/03/14 15:12:51, Justin Novosad wrote: > > > ...
4 years, 9 months ago (2016-03-14 15:46:54 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763043002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763043002/120001
4 years, 9 months ago (2016-03-14 15:49:30 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763043002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763043002/180001
4 years, 9 months ago (2016-03-15 13:25:44 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763043002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763043002/180001
4 years, 9 months ago (2016-03-15 14:44:00 UTC) #21
commit-bot: I haz the power
Committed patchset #10 (id:180001)
4 years, 9 months ago (2016-03-15 14:51:32 UTC) #23
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 14:53:12 UTC) #25
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/1e71ee33752db1b8817870cc25324ae40dbcd6d3
Cr-Commit-Position: refs/heads/master@{#381224}

Powered by Google App Engine
This is Rietveld 408576698