Issue 1763023002: List jmake as an input where it's used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1763023002: List jmake as an input where it's used. (Closed)

Created:
4 years, 9 months ago by agrieve

Modified:
4 years, 9 months ago

Reviewers:
mikecase (-- gone --)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

List jmake as an input where it's used. This ensures that gn gen will fail if the path to jmake is changed. BUG=none

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build/config/android/internal_rules.gni	View		1 chunk	+1 line, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1543003005 Patch 1

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

agrieve

On 2016/03/04 14:37:49, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:mikecase@chromium.org 🔵

4 years, 9 months ago (2016-03-04 14:38:45 UTC) #3

agrieve

4 years, 9 months ago (2016-03-04 15:04:44 UTC) #4

On 2016/03/04 14:38:45, agrieve wrote:
> On 2016/03/04 14:37:49, agrieve wrote:
> > mailto:agrieve@chromium.org changed reviewers:
> > + mailto:mikecase@chromium.org
> 
> 🔵

Turns out the other CL is required for this to work, so combining.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages