Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1763013003: Fix method inference crasher (Closed)

Created:
4 years, 9 months ago by Leaf
Modified:
4 years, 9 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix method inference crasher. During class member inference, only instantiate the type formals of an overridden method when there are type formals to instantiate. BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/6a9af860d04cd2258f5cae74993677272c704832

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M pkg/analyzer/lib/src/task/strong_mode.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 3 chunks +16 lines, -2 lines 2 comments Download

Messages

Total messages: 7 (3 generated)
Leaf
4 years, 9 months ago (2016-03-04 22:54:35 UTC) #3
Jennifer Messerly
lgtm https://codereview.chromium.org/1763013003/diff/1/pkg/analyzer/test/src/task/strong/inferred_type_test.dart File pkg/analyzer/test/src/task/strong/inferred_type_test.dart (right): https://codereview.chromium.org/1763013003/diff/1/pkg/analyzer/test/src/task/strong/inferred_type_test.dart#newcode1845 pkg/analyzer/test/src/task/strong/inferred_type_test.dart:1845: /*=T*/ m/*<T>*/(/*=T*/ x) => x; do/should we also ...
4 years, 9 months ago (2016-03-06 20:20:19 UTC) #4
Leaf
https://codereview.chromium.org/1763013003/diff/1/pkg/analyzer/test/src/task/strong/inferred_type_test.dart File pkg/analyzer/test/src/task/strong/inferred_type_test.dart (right): https://codereview.chromium.org/1763013003/diff/1/pkg/analyzer/test/src/task/strong/inferred_type_test.dart#newcode1845 pkg/analyzer/test/src/task/strong/inferred_type_test.dart:1845: /*=T*/ m/*<T>*/(/*=T*/ x) => x; On 2016/03/06 20:20:19, John ...
4 years, 9 months ago (2016-03-07 18:40:28 UTC) #5
Leaf
4 years, 9 months ago (2016-03-07 18:50:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6a9af860d04cd2258f5cae74993677272c704832 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698