DescriptionRevert of TextIteratorAlgorithm should not force layout update in constructor. (patchset #8 id:130001 of https://codereview.chromium.org/1740173003/ )
Reason for revert:
Suspected of breaking RenderViewImplTest.OnHandleKeyboardEvent on https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20(dbg)
First failing build:
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/19191
Original issue's description:
> TextIteratorAlgorithm should not force layout update in constructor.
>
> Asking to update layout should not be done at this level -- updating layout is part of the document/view lifecycle and should be coordinated at a higher level than an iterator constructor.
>
> Thus, move calling Document::updateLayoutIgnorePendingStylesheets up to the callsites of the TextIterator constructor. These callsites should be audited and moved up even farther up the call stack.
>
> BUG=590295
>
> Committed: https://crrev.com/4ed5e3b54598950731022926b09fdc8742abea74
> Cr-Commit-Position: refs/heads/master@{#379205}
TBR=esprehn@chromium.org,yosin@chromium.org,dglazkov@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=590295
Committed: https://crrev.com/2d8c5743dc6cef1332eb671d9be6c54de00bd611
Cr-Commit-Position: refs/heads/master@{#379265}
Patch Set 1 #Messages
Total messages: 6 (2 generated)
|