Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Issue 1762993002: Revert of TextIteratorAlgorithm should not force layout update in constructor. (Closed)

Created:
4 years, 9 months ago by Marc Treib
Modified:
4 years, 9 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of TextIteratorAlgorithm should not force layout update in constructor. (patchset #8 id:130001 of https://codereview.chromium.org/1740173003/ ) Reason for revert: Suspected of breaking RenderViewImplTest.OnHandleKeyboardEvent on https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20(dbg) First failing build: https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/19191 Original issue's description: > TextIteratorAlgorithm should not force layout update in constructor. > > Asking to update layout should not be done at this level -- updating layout is part of the document/view lifecycle and should be coordinated at a higher level than an iterator constructor. > > Thus, move calling Document::updateLayoutIgnorePendingStylesheets up to the callsites of the TextIterator constructor. These callsites should be audited and moved up even farther up the call stack. > > BUG=590295 > > Committed: https://crrev.com/4ed5e3b54598950731022926b09fdc8742abea74 > Cr-Commit-Position: refs/heads/master@{#379205} TBR=esprehn@chromium.org,yosin@chromium.org,dglazkov@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=590295 Committed: https://crrev.com/2d8c5743dc6cef1332eb671d9be6c54de00bd611 Cr-Commit-Position: refs/heads/master@{#379265}

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
Marc Treib
Created Revert of TextIteratorAlgorithm should not force layout update in constructor.
4 years, 9 months ago (2016-03-04 10:49:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762993002/1
4 years, 9 months ago (2016-03-04 10:49:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 10:49:48 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 10:50:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d8c5743dc6cef1332eb671d9be6c54de00bd611
Cr-Commit-Position: refs/heads/master@{#379265}

Powered by Google App Engine
This is Rietveld 408576698