Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1762943002: Revert of Introduce v8::MicrotasksScope. (Closed)

Created:
4 years, 9 months ago by Michael Achenbach
Modified:
4 years, 9 months ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Introduce v8::MicrotasksScope. (patchset #6 id:100001 of https://codereview.chromium.org/1741893003/ ) Reason for revert: [Sheriff] Speculative. Seems to break a bunch of webkit tests and causes timeouts: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/5103 Please rebase upstream if intended. Original issue's description: > Introduce v8::MicrotasksScope. > > This scope is used to control microtasks execution when MicrotasksPolicy::kScoped is engaged. > > BUG=chromium:585949 > LOG=Y > TEST=ScopedMicrotasks > > Committed: https://crrev.com/db77cec242dbdf8ee26da8232fa930270429f253 > Cr-Commit-Position: refs/heads/master@{#34472} TBR=jochen@chromium.org,adamk@chromium.org,dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:585949 Committed: https://crrev.com/043345a6213ab48a68d71731aa4d54e613fe8ef1 Cr-Commit-Position: refs/heads/master@{#34480}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -343 lines) Patch
M include/v8.h View 2 chunks +11 lines, -61 lines 0 comments Download
M src/api.h View 4 chunks +0 lines, -49 lines 0 comments Download
M src/api.cc View 6 chunks +2 lines, -76 lines 0 comments Download
M src/isolate.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -5 lines 0 comments Download
M test/cctest/test-api.cc View 7 chunks +6 lines, -150 lines 0 comments Download
M test/cctest/test-microtask-delivery.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-thread-termination.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
Created Revert of Introduce v8::MicrotasksScope.
4 years, 9 months ago (2016-03-04 07:30:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762943002/1
4 years, 9 months ago (2016-03-04 07:30:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 07:30:53 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/043345a6213ab48a68d71731aa4d54e613fe8ef1 Cr-Commit-Position: refs/heads/master@{#34480}
4 years, 9 months ago (2016-03-04 07:31:26 UTC) #6
Michael Achenbach
4 years, 9 months ago (2016-03-04 10:08:29 UTC) #7
Message was sent while issue was closed.
FYI: All bots turned green after this revert.

Powered by Google App Engine
This is Rietveld 408576698