Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/thorough/redirect-loop.js

Issue 1762893002: Reland of Set the request mode and the credentials mode of FetchEvent in the service worker correct… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated tyoshino's comment Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/thorough/redirect-loop.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/thorough/redirect-loop.js b/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/thorough/redirect-loop.js
index 31bdae061e4abb6cd3e4bf275a518d931dc5d9c9..6b413a62d2f0d5339722277586629b77386f0e63 100644
--- a/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/thorough/redirect-loop.js
+++ b/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/thorough/redirect-loop.js
@@ -5,42 +5,44 @@ if (self.importScripts) {
var TEST_TARGETS = [
// Redirect loop: same origin -> same origin
- [REDIRECT_LOOP_URL + encodeURIComponent(BASE_URL) + '&Count=20&mode=cors',
+ [REDIRECT_LOOP_URL + encodeURIComponent(BASE_URL) + '&Count=20&mode=cors' +
+ '&credentials=same-origin',
[fetchResolved, hasContentLength, hasBody, typeBasic],
[methodIsGET, authCheck1]],
- [REDIRECT_LOOP_URL + encodeURIComponent(BASE_URL) + '&Count=21&mode=cors',
+ [REDIRECT_LOOP_URL + encodeURIComponent(BASE_URL) + '&Count=21&mode=cors' +
+ '&credentials=same-origin',
[fetchRejected]],
// Redirect loop: same origin -> other origin
[REDIRECT_LOOP_URL + encodeURIComponent(OTHER_BASE_URL + '&ACAOrigin=*') +
- '&Count=20&mode=cors&method=GET',
+ '&Count=20&mode=cors&credentials=same-origin&method=GET',
[fetchResolved, noContentLength, noServerHeader, hasBody, typeCors],
[methodIsGET, authCheckNone]],
// FIXME: due to the current implementation of Chromium,
// Count=21 is resolved, Count=22 is rejected.
// https://crbug.com/353768
[REDIRECT_LOOP_URL + encodeURIComponent(OTHER_BASE_URL + '&ACAOrigin=*') +
- '&Count=22&mode=cors&method=GET',
+ '&Count=22&mode=cors&credentials=same-origin&method=GET',
[fetchRejected]],
// Redirect loop: other origin -> same origin
[OTHER_REDIRECT_LOOP_URL + encodeURIComponent(BASE_URL + 'ACAOrigin=*') +
- '&Count=20&mode=cors&method=GET&ACAOrigin=*',
+ '&Count=20&mode=cors&credentials=same-origin&method=GET&ACAOrigin=*',
[fetchResolved, noContentLength, noServerHeader, hasBody, typeCors],
[methodIsGET, authCheckNone]],
[OTHER_REDIRECT_LOOP_URL + encodeURIComponent(BASE_URL + 'ACAOrigin=*') +
- '&Count=21&mode=cors&method=GET&ACAOrigin=*',
+ '&Count=21&mode=cors&credentials=same-origin&method=GET&ACAOrigin=*',
[fetchRejected]],
// Redirect loop: other origin -> other origin
[OTHER_REDIRECT_LOOP_URL +
encodeURIComponent(OTHER_BASE_URL + 'ACAOrigin=*') +
- '&Count=20&mode=cors&method=GET&ACAOrigin=*',
+ '&Count=20&mode=cors&credentials=same-origin&method=GET&ACAOrigin=*',
[fetchResolved, noContentLength, noServerHeader, hasBody, typeCors],
[methodIsGET, authCheckNone]],
[OTHER_REDIRECT_LOOP_URL +
encodeURIComponent(OTHER_BASE_URL + 'ACAOrigin=*') +
- '&Count=21&mode=cors&method=GET&ACAOrigin=*',
+ '&Count=21&mode=cors&credentials=same-origin&method=GET&ACAOrigin=*',
[fetchRejected]],
];

Powered by Google App Engine
This is Rietveld 408576698