Disable window occlusion APIs when running browser tests

Disable window occlusion APIs when running browser tests

The positioning of windows is not predictable when running tests, and
some tests can end up having their renderer processes backgrounded
due to occlusion, causing unpredictable behavior.

Disable occlusion API use when running tests. Occlusion is a Mac-only
API for the moment, but leave this as non-Mac so that it can be picked
up if needed.

Also, get rid of the "we're on 10.9+" check. We always are now.

BUG=558585
Committed: https://crrev.com/19b720a9ad1f5a0ce9e432e275d2a61a15c6ceac
Cr-Commit-Position: refs/heads/master@{#379500}

[ccameron, 2016-03-03 23:31:44]

Description was changed from

==========
Disable window occlusion APIs when running browser tests

The positioning of windows is not predictable when running tests, and
some tests can end up having their renderer processes backgrounded
due to occlusion, causing unpredictable behavior.

Disable occlusion API use when running tests. Occlusion is a Mac-only
API for the moment, but leave this as non-Mac so that it can be picked
up if needed.

BUG=558585
==========

to

==========
Disable window occlusion APIs when running browser tests

The positioning of windows is not predictable when running tests, and
some tests can end up having their renderer processes backgrounded
due to occlusion, causing unpredictable behavior.

Disable occlusion API use when running tests. Occlusion is a Mac-only
API for the moment, but leave this as non-Mac so that it can be picked
up if needed.

Also, get rid of the "we're on 10.9+" check. We always are now.

BUG=558585
==========

[ccameron, 2016-03-03 23:31:44]

ccameron@chromium.org changed reviewers:
+ avi@chromium.org

[ccameron, 2016-03-03 23:32:16]

This will unblock the linked bug ... I wonder if it will have any other effects
on flakes on Mac.

[Noel Gordon, 2016-03-04 01:57:31]

noel@chromium.org changed reviewers:
+ noel@chromium.org

[Noel Gordon, 2016-03-04 01:57:32]

https://codereview.chromium.org/1762883002/diff/1/content/browser/web_content...
File content/browser/web_contents/web_contents_view_mac.mm (right):

https://codereview.chromium.org/1762883002/diff/1/content/browser/web_content...
content/browser/web_contents/web_contents_view_mac.mm:642: // flakily change
behavior.
"change" - > "change test" ?

https://codereview.chromium.org/1762883002/diff/1/content/browser/web_content...
content/browser/web_contents/web_contents_view_mac.mm:643: static bool
isDisabled = base::CommandLine::ForCurrentProcess()->HasSwitch(
Is using a static safe for all test scenarios?

https://codereview.chromium.org/1762883002/diff/1/content/public/test/browser...
File content/public/test/browser_test_base.cc (right):

https://codereview.chromium.org/1762883002/diff/1/content/public/test/browser...
content/public/test/browser_test_base.cc:203: // The layout of windows on screen
is unpredictable during, so disable
"during" -> "during tests" ?

[Avi (use Gerrit), 2016-03-04 17:31:38]

LGTM

https://codereview.chromium.org/1762883002/diff/1/content/public/common/conte...
File content/public/common/content_switches.h (right):

https://codereview.chromium.org/1762883002/diff/1/content/public/common/conte...
content/public/common/content_switches.h:38: CONTENT_EXPORT extern const char
kDisableBackgroundingOccludedWindows[];
...ForTesting ?

[ccameron, 2016-03-06 23:09:08]

Thanks!

https://codereview.chromium.org/1762883002/diff/1/content/browser/web_content...
File content/browser/web_contents/web_contents_view_mac.mm (right):

https://codereview.chromium.org/1762883002/diff/1/content/browser/web_content...
content/browser/web_contents/web_contents_view_mac.mm:642: // flakily change
behavior.
On 2016/03/04 01:57:32, noel gordon wrote:
> "change" - > "change test" ?

Done.

https://codereview.chromium.org/1762883002/diff/1/content/browser/web_content...
content/browser/web_contents/web_contents_view_mac.mm:643: static bool
isDisabled = base::CommandLine::ForCurrentProcess()->HasSwitch(
On 2016/03/04 01:57:32, noel gordon wrote:
> Is using a static safe for all test scenarios?

I tested single and multi-process and both worked. I've also added the
"ForTesting" suffix to ensure that people don't think this is a good idea
outside of tests.

https://codereview.chromium.org/1762883002/diff/1/content/public/common/conte...
File content/public/common/content_switches.h (right):

https://codereview.chromium.org/1762883002/diff/1/content/public/common/conte...
content/public/common/content_switches.h:38: CONTENT_EXPORT extern const char
kDisableBackgroundingOccludedWindows[];
On 2016/03/04 17:31:38, Avi wrote:
> ...ForTesting ?

Done.

https://codereview.chromium.org/1762883002/diff/1/content/public/test/browser...
File content/public/test/browser_test_base.cc (right):

https://codereview.chromium.org/1762883002/diff/1/content/public/test/browser...
content/public/test/browser_test_base.cc:203: // The layout of windows on screen
is unpredictable during, so disable
On 2016/03/04 01:57:32, noel gordon wrote:
> "during" -> "during tests" ?

Thanks -- fixed.

[ccameron, 2016-03-06 23:09:14]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-03-06 23:09:15]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1762883002/#ps20001
(title: "Feedback")

[commit-bot: I haz the power, 2016-03-06 23:09:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1762883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1762883002/20001

[commit-bot: I haz the power, 2016-03-07 00:14:44]

Description was changed from

==========
Disable window occlusion APIs when running browser tests

The positioning of windows is not predictable when running tests, and
some tests can end up having their renderer processes backgrounded
due to occlusion, causing unpredictable behavior.

Disable occlusion API use when running tests. Occlusion is a Mac-only
API for the moment, but leave this as non-Mac so that it can be picked
up if needed.

Also, get rid of the "we're on 10.9+" check. We always are now.

BUG=558585
==========

to

==========
Disable window occlusion APIs when running browser tests

The positioning of windows is not predictable when running tests, and
some tests can end up having their renderer processes backgrounded
due to occlusion, causing unpredictable behavior.

Disable occlusion API use when running tests. Occlusion is a Mac-only
API for the moment, but leave this as non-Mac so that it can be picked
up if needed.

Also, get rid of the "we're on 10.9+" check. We always are now.

BUG=558585
==========

[commit-bot: I haz the power, 2016-03-07 00:14:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-07 00:15:54]

Description was changed from

==========
Disable window occlusion APIs when running browser tests

The positioning of windows is not predictable when running tests, and
some tests can end up having their renderer processes backgrounded
due to occlusion, causing unpredictable behavior.

Disable occlusion API use when running tests. Occlusion is a Mac-only
API for the moment, but leave this as non-Mac so that it can be picked
up if needed.

Also, get rid of the "we're on 10.9+" check. We always are now.

BUG=558585
==========

to

==========
Disable window occlusion APIs when running browser tests

The positioning of windows is not predictable when running tests, and
some tests can end up having their renderer processes backgrounded
due to occlusion, causing unpredictable behavior.

Disable occlusion API use when running tests. Occlusion is a Mac-only
API for the moment, but leave this as non-Mac so that it can be picked
up if needed.

Also, get rid of the "we're on 10.9+" check. We always are now.

BUG=558585

Committed: https://crrev.com/19b720a9ad1f5a0ce9e432e275d2a61a15c6ceac
Cr-Commit-Position: refs/heads/master@{#379500}
==========

[commit-bot: I haz the power, 2016-03-07 00:15:55]

Patchset 2 (id:??) landed as
https://crrev.com/19b720a9ad1f5a0ce9e432e275d2a61a15c6ceac
Cr-Commit-Position: refs/heads/master@{#379500}

[Noel Gordon, 2016-03-07 00:50:49]

Description was changed from

==========
Disable window occlusion APIs when running browser tests

The positioning of windows is not predictable when running tests, and
some tests can end up having their renderer processes backgrounded
due to occlusion, causing unpredictable behavior.

Disable occlusion API use when running tests. Occlusion is a Mac-only
API for the moment, but leave this as non-Mac so that it can be picked
up if needed.

Also, get rid of the "we're on 10.9+" check. We always are now.

BUG=558585

Committed: https://crrev.com/19b720a9ad1f5a0ce9e432e275d2a61a15c6ceac
Cr-Commit-Position: refs/heads/master@{#379500}
==========

to

==========
Disable window occlusion APIs when running browser tests

The positioning of windows is not predictable when running tests, and
some tests can end up having their renderer processes backgrounded
due to occlusion, causing unpredictable behavior.

Disable occlusion API use when running tests. Occlusion is a Mac-only
API for the moment, but leave this as non-Mac so that it can be picked
up if needed.

Also, get rid of the "we're on 10.9+" check. We always are now.

BUG=558585

Committed: https://crrev.com/19b720a9ad1f5a0ce9e432e275d2a61a15c6ceac
Cr-Commit-Position: refs/heads/master@{#379500}
==========

[Noel Gordon, 2016-03-07 00:51:59]

LGTM