Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1762873002: Revert of add --gdb-index to linker (Closed)

Created:
4 years, 9 months ago by stevenjb
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke, Nico, atotic1
CC:
chromium-reviews, Lei Zhang, mithro
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of add --gdb-index to linker (patchset #2 id:20001 of https://codereview.chromium.org/1680943002/ ) Reason for revert: We suspect this may be causing an increase in binary size on some chromeos PFQ builders. Reverting to see if this is the cause. Original issue's description: > add --gdb-index to linker > > gold linker has a flag to automatically generate gdb-index section > inside shared libraries when linking. > > Webkit single-file compile/linking time: > > 16.31s without gdb-index > 16.11s with gdb-index > > gdb startup time > > ~51s without gdb-index > ~19s with gdb-index > > BUG= > > Committed: https://crrev.com/f68b7c07a30baac088b8eda055ba52835c04692c > Cr-Commit-Position: refs/heads/master@{#378600} TBR=dpranke@chromium.org,thakis@chromium.org,atotic@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/b3521bc11841b49542d4b4c6a415167202ae151b Cr-Commit-Position: refs/heads/master@{#379165}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (2 generated)
stevenjb
Created Revert of add --gdb-index to linker
4 years, 9 months ago (2016-03-03 22:28:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762873002/1
4 years, 9 months ago (2016-03-03 22:29:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762873002/1
4 years, 9 months ago (2016-03-03 22:32:29 UTC) #3
Dirk Pranke
lgtm. We can make this be desktop linux-only and/or debug-only as needed if this is ...
4 years, 9 months ago (2016-03-03 22:34:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762873002/1
4 years, 9 months ago (2016-03-03 23:01:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762873002/1
4 years, 9 months ago (2016-03-03 23:31:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762873002/1
4 years, 9 months ago (2016-03-04 00:01:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762873002/1
4 years, 9 months ago (2016-03-04 00:31:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762873002/1
4 years, 9 months ago (2016-03-04 01:01:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 01:30:25 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b3521bc11841b49542d4b4c6a415167202ae151b Cr-Commit-Position: refs/heads/master@{#379165}
4 years, 9 months ago (2016-03-04 01:31:24 UTC) #13
stevenjb
4 years, 9 months ago (2016-03-04 23:02:18 UTC) #14
Message was sent while issue was closed.
On 2016/03/04 01:31:24, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/b3521bc11841b49542d4b4c6a415167202ae151b
> Cr-Commit-Position: refs/heads/master@{#379165}

The revert did in fact fix the problem on Chrome OS, so let's not do this there
:)

FWIW, it only seemed to affect official chrome builders, not chromium os
builders.

Powered by Google App Engine
This is Rietveld 408576698