Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 1762843002: Fix logic handling empty strings in tts. (Closed)

Created:
4 years, 9 months ago by David Tseng
Modified:
4 years, 9 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix logic handling empty strings in tts. Previously, we explicitly stopped speech when encountering a call to speak only whitespace. However, since sometimes we get whitespace from an unreliable source, it can actually cause other utterances to be interrupted. One such example is Sheets. When arrowing around, we observe some events resulting in empty speech which interrupts cell announcement. Committed: https://crrev.com/112cdcfa70a21b026abe0228c9b5ebb2fb287a3e Cr-Commit-Position: refs/heads/master@{#379308}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background.js View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
David Tseng
4 years, 9 months ago (2016-03-03 22:13:54 UTC) #3
dmazzoni
lgtm
4 years, 9 months ago (2016-03-03 23:51:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762843002/1
4 years, 9 months ago (2016-03-04 17:04:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 17:51:39 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/112cdcfa70a21b026abe0228c9b5ebb2fb287a3e Cr-Commit-Position: refs/heads/master@{#379308}
4 years, 9 months ago (2016-03-04 17:53:33 UTC) #10
David Tseng
4 years, 9 months ago (2016-03-08 20:13:59 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1770943004/ by dtseng@chromium.org.

The reason for reverting is: It turns out this causes Output.flushNextUtterance
to not get applied correctly. Output sometimes sends an empty string as its
first utterance..

Powered by Google App Engine
This is Rietveld 408576698