Remove runtime toggling of throttling frames

Remove runtime toggling of throttling frames

This was added in https://codereview.chromium.org/811523002, but was
never actually hooked up to anything.  So, time to remove it.  Sorry
year old feature that never got finished, your time can come again.

This is just scheduler cleanup to make it possible to do further begin
frame source refactoring.  The followups to this patch are to make
scheduler not own any begin frame source (always external, from its
perspective) and then make it possible to remove/change the begin frame
source the scheduler is using.

Committed: https://crrev.com/1e43e0d8e6dc2ec7c73a2587d21c079663e89159
Cr-Commit-Position: refs/heads/master@{#380000}

[enne (OOO), 2016-03-03 21:24:51]

Description was changed from

==========
Remove runtime toggling of throttling frames

This was added in https://codereview.chromium.org/811523002, but was
never actually hooked up to anything.  So, time to remove it.  Sorry
year old feature that never got finished, your time can come again.

This is just scheduler cleanup to make it possible to do further begin
frame source refactoring.  The followups to this patch are to make
scheduler not own any begin frame source (always external, from its
perspective) and then make it possible to remove/change the begin frame
source the scheduler is using.
==========

to

==========
Remove runtime toggling of throttling frames

This was added in https://codereview.chromium.org/811523002, but was
never actually hooked up to anything.  So, time to remove it.  Sorry
year old feature that never got finished, your time can come again.

This is just scheduler cleanup to make it possible to do further begin
frame source refactoring.  The followups to this patch are to make
scheduler not own any begin frame source (always external, from its
perspective) and then make it possible to remove/change the begin frame
source the scheduler is using.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[enne (OOO), 2016-03-03 21:25:20]

Description was changed from

==========
Remove runtime toggling of throttling frames

This was added in https://codereview.chromium.org/811523002, but was
never actually hooked up to anything.  So, time to remove it.  Sorry
year old feature that never got finished, your time can come again.

This is just scheduler cleanup to make it possible to do further begin
frame source refactoring.  The followups to this patch are to make
scheduler not own any begin frame source (always external, from its
perspective) and then make it possible to remove/change the begin frame
source the scheduler is using.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Remove runtime toggling of throttling frames

This was added in https://codereview.chromium.org/811523002, but was
never actually hooked up to anything.  So, time to remove it.  Sorry
year old feature that never got finished, your time can come again.

This is just scheduler cleanup to make it possible to do further begin
frame source refactoring.  The followups to this patch are to make
scheduler not own any begin frame source (always external, from its
perspective) and then make it possible to remove/change the begin frame
source the scheduler is using.
==========

[enne (OOO), 2016-03-03 21:25:20]

enne@chromium.org changed reviewers:
+ skyostil@chromium.org, sunnyps@chromium.org

[enne (OOO), 2016-03-03 21:26:02]

I already talked to bajones about this who gave his ok to remove this.

[sunnyps, 2016-03-03 22:43:11]

Besides the stuff bajones had asked for, this is also used for disabling vsync
using a command line switch. Is that use case also not valid any more?

[enne (OOO), 2016-03-03 22:45:01]

On 2016/03/03 at 22:43:11, sunnyps wrote:
> Besides the stuff bajones had asked for, this is also used for disabling vsync
using a command line switch. Is that use case also not valid any more?

Still valid, but it just has to be done via LayerTreeSettings and not toggled. 
After the patch sequence that I describe above, it would be possible for the
owner of a cc::Scheduler to change the BeginFrameSource to an unthrottled one to
reimplement this in the future.  I just wanted to hoist the complexity out of
scheduler itself.

[sunnyps, 2016-03-03 22:46:52]

Ok. I'll probably not get around to this today because of a ChromeOS GPU process
issue that I'm debugging.

[enne (OOO), 2016-03-08 23:19:23]

Ping?

[sunnyps, 2016-03-08 23:24:43]

LGTM

[enne (OOO), 2016-03-08 23:29:45]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2016-03-08 23:30:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1762823002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1762823002/1

[commit-bot: I haz the power, 2016-03-09 00:47:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-09 00:48:36]

Description was changed from

==========
Remove runtime toggling of throttling frames

This was added in https://codereview.chromium.org/811523002, but was
never actually hooked up to anything.  So, time to remove it.  Sorry
year old feature that never got finished, your time can come again.

This is just scheduler cleanup to make it possible to do further begin
frame source refactoring.  The followups to this patch are to make
scheduler not own any begin frame source (always external, from its
perspective) and then make it possible to remove/change the begin frame
source the scheduler is using.
==========

to

==========
Remove runtime toggling of throttling frames

This was added in https://codereview.chromium.org/811523002, but was
never actually hooked up to anything.  So, time to remove it.  Sorry
year old feature that never got finished, your time can come again.

This is just scheduler cleanup to make it possible to do further begin
frame source refactoring.  The followups to this patch are to make
scheduler not own any begin frame source (always external, from its
perspective) and then make it possible to remove/change the begin frame
source the scheduler is using.

Committed: https://crrev.com/1e43e0d8e6dc2ec7c73a2587d21c079663e89159
Cr-Commit-Position: refs/heads/master@{#380000}
==========

[commit-bot: I haz the power, 2016-03-09 00:48:37]

Patchset 1 (id:??) landed as
https://crrev.com/1e43e0d8e6dc2ec7c73a2587d21c079663e89159
Cr-Commit-Position: refs/heads/master@{#380000}