Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 1762743002: S390: Initial impl of turbofan compiler (Closed)

Created:
4 years, 9 months ago by john.yan
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1397 lines, -1157 lines) Patch
M BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/c-linkage.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +2 lines, -0 lines 0 comments Download
A + src/compiler/s390/code-generator-s390.cc View 42 chunks +794 lines, -761 lines 0 comments Download
A src/compiler/s390/instruction-codes-s390.h View 1 chunk +154 lines, -0 lines 0 comments Download
A src/compiler/s390/instruction-scheduler-s390.cc View 1 chunk +157 lines, -0 lines 0 comments Download
A + src/compiler/s390/instruction-selector-s390.cc View 50 chunks +244 lines, -396 lines 0 comments Download
M src/compiler/wasm-linkage.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
john.yan
S390: Initial impl of turbofan compiler
4 years, 9 months ago (2016-03-03 18:47:23 UTC) #1
michael_dawson
On 2016/03/03 18:47:23, john.yan wrote: > S390: Initial impl of turbofan compiler lgtm
4 years, 9 months ago (2016-03-03 19:39:59 UTC) #2
Jakob Kummerow
LGTM (rubberstamping *-s390.(h|cc), actually reviewed the rest). +mstarzinger for compiler/OWNERS review.
4 years, 9 months ago (2016-03-04 10:48:05 UTC) #4
Michael Starzinger
LGTM on the compiler back-end pieces.
4 years, 9 months ago (2016-03-04 11:00:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762743002/1
4 years, 9 months ago (2016-03-04 15:18:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762743002/1
4 years, 9 months ago (2016-03-04 15:19:22 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 15:38:24 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 15:38:47 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a9ecc129fa1bbfab7d18db0536bc7c9544efe7f
Cr-Commit-Position: refs/heads/master@{#34501}

Powered by Google App Engine
This is Rietveld 408576698