Adding variable builder for mac asan

Adding variable builder for mac asan

BUG=591879
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299115

[lijeffrey, 2016-03-04 01:16:03]

Description was changed from

==========
Adding variable builder for mac asan

BUG=
==========

to

==========
Adding variable builder for mac asan

BUG=591879
==========

[lijeffrey, 2016-03-04 01:16:04]

lijeffrey@chromium.org changed reviewers:
+ iannucci@chromium.org, sergeyberezin@chromium.org, stgao@chromium.org

[lijeffrey, 2016-03-04 01:26:24]

Hey guys, this change is to add a mac variable builder for asan builds. PTAL
when you have the chance :)

Thanks,
Jeff

[iannucci, 2016-03-04 01:51:11]

lgtm

[Sergey Berezin, 2016-03-04 01:57:25]

Code LGTM, but watch out for the available disk space on the bots:
http://shortn/_GdYBBju7J5

Is "mac_asan" shared by an existing builder, or is it a new one on these slaves?
If it's a new one, do you know the size of the checkout (together with all build
artifacts), and if the available space is enough?

In fact, vm1025-m4 seems to be having a really bad time with disk space
lately... You may want to go/bug-a-trooper . 

vm1026-m4 is at 70GB of free space, so that's probably OK.

[lijeffrey, 2016-03-04 02:19:43]

On 2016/03/04 01:57:25, Sergey Berezin wrote:
> Code LGTM, but watch out for the available disk space on the bots:
> http://shortn/_GdYBBju7J5
> 
> Is "mac_asan" shared by an existing builder, or is it a new one on these
slaves?
> If it's a new one, do you know the size of the checkout (together with all
build
> artifacts), and if the available space is enough?
> 
> In fact, vm1025-m4 seems to be having a really bad time with disk space
> lately... You may want to go/bug-a-trooper . 
> 
> vm1026-m4 is at 70GB of free space, so that's probably OK.

Thanks Sergey for the heads up! Yes, mac_asan should be a new directory. I'm
unsure about the size of the checkout but < 10 MB available on one of the
assigned bots sounds way too small, so I've logged
https://bugs.chromium.org/p/chromium/issues/detail?id=591892 for a trooper to
investigate vm1025-m4's disk woes. In the meantime I'll hold off on committing
this change until 591892 is addressed to avoid running into problems.

[lijeffrey, 2016-03-04 19:23:03]

The CQ bit was checked by lijeffrey@chromium.org

[commit-bot: I haz the power, 2016-03-04 19:23:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1762723003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1762723003/40001

[commit-bot: I haz the power, 2016-03-04 19:26:44]

Description was changed from

==========
Adding variable builder for mac asan

BUG=591879
==========

to

==========
Adding variable builder for mac asan

BUG=591879

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299115
==========

[commit-bot: I haz the power, 2016-03-04 19:26:45]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299115