Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Issue 1762723002: Cleanup 1: split parts into their own libraries, remove unused imports (Closed)

Created:
4 years, 9 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 9 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cleanup 1: split parts into their own libraries for: tree, helpers, ssa, native. In the case of ssa, I also removed references to AST nodes in ssa nodes that were unused, so now only the builder imports the AST. I also got rid of unused imports from everywhere else in the code. R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/0f979d529d31f452301f54c24c58f5a85d6f97d5

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+429 lines, -285 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/backward_null_check_remover.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/bounds_checker.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/gvn.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/path_based_optimizer.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/dart_types.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/helpers/debug_collection.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/helpers/expensive_map.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/helpers/expensive_set.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/helpers/helpers.dart View 1 chunk +8 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/helpers/stats.dart View 1 chunk +11 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/helpers/trace.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/helpers/track_map.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/info/send_info.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_impact.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/js_interop_analysis.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/constant_ordering.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/model.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 1 chunk +22 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 1 chunk +40 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/native/js.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/native/native.dart View 1 chunk +6 lines, -51 lines 0 comments Download
M pkg/compiler/lib/src/native/scanner.dart View 1 chunk +11 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/native/ssa.dart View 1 chunk +19 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 5 chunks +85 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 3 chunks +42 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen_helpers.dart View 1 chunk +8 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/interceptor_simplifier.dart View 1 chunk +13 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart View 1 chunk +12 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 5 chunks +25 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 3 chunks +37 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 1 chunk +1 line, -77 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa_tracer.dart View 1 chunk +6 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types.dart View 1 chunk +9 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/types_propagation.dart View 1 chunk +9 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/validate.dart View 1 chunk +2 lines, -1 line 2 comments Download
M pkg/compiler/lib/src/ssa/value_range_analyzer.dart View 1 chunk +9 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/value_set.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/variable_allocator.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/tracer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/tree/dartstring.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 1 chunk +11 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/tree/prettyprint.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/tree/tree.dart View 1 chunk +4 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/tree/unparser.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/types/abstract_value_domain.dart View 1 chunk +1 line, -6 lines 0 comments Download
M pkg/compiler/lib/src/universe/class_set.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/side_effects.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_impact.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Siggi Cherem (dart-lang)
4 years, 9 months ago (2016-03-03 18:18:07 UTC) #3
sra1
lgtm https://codereview.chromium.org/1762723002/diff/1/pkg/compiler/lib/src/ssa/validate.dart File pkg/compiler/lib/src/ssa/validate.dart (right): https://codereview.chromium.org/1762723002/diff/1/pkg/compiler/lib/src/ssa/validate.dart#newcode5 pkg/compiler/lib/src/ssa/validate.dart:5: extra line
4 years, 9 months ago (2016-03-04 01:21:10 UTC) #4
Siggi Cherem (dart-lang)
Committed patchset #1 (id:1) manually as 0f979d529d31f452301f54c24c58f5a85d6f97d5 (presubmit successful).
4 years, 9 months ago (2016-03-14 21:03:41 UTC) #6
Siggi Cherem (dart-lang)
4 years, 9 months ago (2016-03-14 21:05:30 UTC) #7
Message was sent while issue was closed.
thanks

https://codereview.chromium.org/1762723002/diff/1/pkg/compiler/lib/src/ssa/va...
File pkg/compiler/lib/src/ssa/validate.dart (right):

https://codereview.chromium.org/1762723002/diff/1/pkg/compiler/lib/src/ssa/va...
pkg/compiler/lib/src/ssa/validate.dart:5: 
On 2016/03/04 01:21:10, sra1 wrote:
> extra line

Done.

Powered by Google App Engine
This is Rietveld 408576698