Chromium Code Reviews Chromium Code Reviews
Issue
1762703004:
Revert of Canvas Capture: chrome browsertest- added frame rate test (Closed)
DescriptionRevert of Canvas Capture: chrome browsertest- added frame rate test (patchset #5 id:180001 of https://codereview.chromium.org/1692773002/ )
Reason for revert:
This CL caused uninitialized memory access errors in the new test. See here for the first build where this occurred:
https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Tests/builds/7743
here is some sample output:
WebRtcCanvasCaptureBrowserTest.VerifyCanvasCaptureFrameRate (run #1):
[ RUN ] WebRtcCanvasCaptureBrowserTest.VerifyCanvasCaptureFrameRate
[29378:29378:0303/133319:WARNING:chrome_browser_main_chromeos.cc(336)] Running as stub user with profile dir: test-user
[29378:29378:0303/133319:WARNING:statistics_provider.cc(251)] Statistics loaded after waiting 2ms.
Xlib: extension "RANDR" missing on display ":9".
[29378:29378:0303/133319:INFO:lock_state_controller.cc(95)] Constructing LockStateController instance 0x72a00000e600
[29378:29465:0303/133319:WARNING:local_extension_cache.cc(259)] Extensions will not be installed from update URLs until /tmp/.org.chromium.Chromium.bKaPXe/ddd7Mcg/stub_device_local_extension_cache/.initialized exists.
[29378:29378:0303/133320:WARNING:child_account_service.cc(289)] User instance wasn't found while setting child account flag.
[29378:29469:0303/133320:WARNING:freezer_cgroup_process_manager.cc(59)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes.
[29378:29378:0303/133320:INFO:power_button_observer.cc(37)] Creating PowerButtonObserver 0x7060001e9ae0
[29378:29378:0303/133320:INFO:lock_state_controller.cc(235)] LockStateController::OnLoginStateChanged login_status_: 0, status: 2
[29378:29378:0303/133320:WARNING:suggestions_service.cc(155)] Token error: Not authorized.
Uninitialized bytes in __interceptor_strlen at offset 20 inside [0x73e00000ee00, 3280)
==29483==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x7f8620d25de8 in ?? ??:0
#1 0x7f8620d2b3f8 in ?? ??:0
#2 0x7f8620d27a17 in ?? ??:0
#3 0x7f8620d27c55 in ?? ??:0
#4 0xb07a8e2 in glXQueryExtensionsStringFn ui/gl/gl_glx_api_implementation.cc:91:21
#5 0xb1470ff in GetPlatformExtensions ui/gl/gl_bindings.cc:59:21
#6 0xb13fb9c in InitializeExtensionBindings ui/gl/gl_bindings_autogen_glx.cc:118:26
#7 0xb058ed0 in InitializeStaticGLBindings ui/gl/gl_implementation_x11.cc:102:7
#8 0xb1153c1 in ?? ui/gl/gl_surface.cc:75:7
#9 0xb114e69 in InitializeOneOff ui/gl/gl_surface.cc:65:10
#10 0x1eaeaf86 in GpuMain content/gpu/gpu_main.cc:295:15
#11 0x1a310e81 in RunNamedProcessTypeMain content/app/content_main_runner.cc:395:14
#12 0x1a31422a in Run content/app/content_main_runner.cc:766:12
#13 0x1a30ca37 in ContentMain content/app/content_main.cc:19:15
#14 0x1a3e5050 in LaunchTests content/public/test/test_launcher.cc:505:12
#15 0x5680cbf in LaunchChromeTests chrome/test/base/chrome_test_launcher.cc:128:10
#16 0x3167cec in main chrome/test/base/browser_tests_main.cc:21:10
#17 0x7f862401a76c in __libc_start_main /build/eglibc-rrybNj/eglibc-2.15/csu/libc-start.c:226:0
#18 0x76ae88 in _start ??:0
Uninitialized value was created by a heap allocation
#0 0x78f8c2 in malloc ??:0
#1 0x7f8620d2b972 in ?? ??:0
SUMMARY: MemorySanitizer: use-of-uninitialized-value (/usr/lib/x86_64-linux-gnu/mesa/libGL.so.1+0x1ade8)
Exiting
Original issue's description:
> Canvas Capture: chrome browsertest- added frame rate test
>
> This CL introduces a new chrome browser test for canvas capture.
> The test verifies that the canvas capture frame rate is as expected.
>
> BUG=524218, 586316
> TEST=On linux host and trybots
>
> Committed: https://crrev.com/7a05c134dedd0137c23ba43b42db8f1e513cd9e6
> Cr-Commit-Position: refs/heads/master@{#379065}
TBR=phoglund@chromium.org,emircan@chromium.org,cpaulin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=524218, 586316
Committed: https://crrev.com/72fe529da92f9a1317a08f99cbfe78157756378d
Cr-Commit-Position: refs/heads/master@{#379183}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||
