DescriptionRevert of Evict non-secure cookies less agressively. (patchset #4 id:60001 of https://codereview.chromium.org/1705753002/ )
Reason for revert:
Let's see if the automagical reversion thingie will work on a ~2 week old patch.
```
I updated the eviction algorithm with our initial pass at a merger between leave-secure-cookies-along and cookie-priorities, and neglected to ensure that that new algorithm was safely locked up behind the "strict secure cookies" experiment. That patch is in M50.
I think the right thing to do is to revert https://codereview.chromium.org/1705753002 on the M50 branch so that we retain the status quo behavior for beta. That means that we're going to have to wait a bit longer to start ratcheting down on cookies, which is unfortunate, but the safe choice this late in the game.
```
BUG=591720
Original issue's description:
> Evict non-secure cookies less agressively.
>
> The current implementation of strict-secure cookies wipes all non-secure
> cookies when an origin exceeds ~180. This is a bit agressive, and has
> real impact on users.
>
> This patch softens that to remove only the number of non-secure cookies
> necessary to get under the ~150 cap. If a user has 150 secure cookies,
> we'll still wipe all non-secure cookies, but that seems less likely to
> impact users than the current behavior.
>
> The patch is a bit more complicated than I expected due to interactions
> with the Chrome-only "priority" feature we shipped back in 2013. In
> short, we execute priority-driven removal of non-secure cookies first,
> and only touch secure cookies if necessary.
>
> BUG=581588
> R=mmenke@chromium.org, jww@chromium.org
>
> Committed: https://crrev.com/162d27135f2ee44ae01341de055d1b827a930767
> Cr-Commit-Position: refs/heads/master@{#376204}
TBR=jww@chromium.org,mmenke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=581588
Committed: https://crrev.com/8773435ab4441ce8f78611b694e92659e9b50a63
Cr-Commit-Position: refs/heads/master@{#379030}
Patch Set 1 #
Messages
Total messages: 8 (1 generated)
|