Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1762673002: Fix RenderViewImplTest.GetCompositionCharacterBoundsTest (Closed)

Created:
4 years, 9 months ago by kojii
Modified:
4 years, 9 months ago
Reviewers:
nasko
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, yosin_UTC9
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix RenderViewImplTest.GetCompositionCharacterBoundsTest This test expects OnImeSetComposition() returns width=0 for between surrogate pairs. In Blink, this calls: Editor::firstRectForRange(const EphemeralRange& range) which generates the character bounds from the caret position of downstream and upstream. In this specific case, when the test run with fonts that has more code point coverage, the line wraps, and Editor adds |extraWidthToEndOfLine| which confuses the test. This patch fixes the test by not to wrap the line, BUG=508747 Committed: https://crrev.com/378d5bc14d6503b04787acfe9df3e18f0acb647b Cr-Commit-Position: refs/heads/master@{#379086}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M content/renderer/render_view_browsertest.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kojii
PTAL.
4 years, 9 months ago (2016-03-03 14:23:55 UTC) #3
nasko
LGTM
4 years, 9 months ago (2016-03-03 18:09:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762673002/1
4 years, 9 months ago (2016-03-03 20:55:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 21:02:42 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 21:03:54 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/378d5bc14d6503b04787acfe9df3e18f0acb647b
Cr-Commit-Position: refs/heads/master@{#379086}

Powered by Google App Engine
This is Rietveld 408576698