Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1762663002: Add support for ConstructorElementImpl.isCycleFree to summaries. (Closed)

Created:
4 years, 9 months ago by Paul Berry
Modified:
4 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for ConstructorElementImpl.isCycleFree to summaries. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/c46f593b33db82615fe9b2e3857d368295340da1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -36 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 15 chunks +66 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View 2 chunks +16 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 2 chunks +18 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 4 chunks +10 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 6 chunks +12 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 5 chunks +35 lines, -14 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 6 chunks +43 lines, -10 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 9 months ago (2016-03-03 14:01:10 UTC) #2
scheglov
LGTM
4 years, 9 months ago (2016-03-03 15:44:25 UTC) #3
Paul Berry
4 years, 9 months ago (2016-03-03 19:00:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c46f593b33db82615fe9b2e3857d368295340da1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698