ios/chrome/browser/passwords/credential_manager.h - Issue 1762603002: Switch components/password_manager code from IPC messages to Mojo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/passwords/credential_manager.h

Issue 1762603002: Switch components/password_manager code from IPC messages to Mojo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gyp Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/content/renderer/credential_manager_client_browsertest.cc ('K') | « components/password_manager/core/common/credential_manager_types.cc ('k') | ios/chrome/browser/passwords/credential_manager.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/passwords/credential_manager.h

diff --git a/ios/chrome/browser/passwords/credential_manager.h b/ios/chrome/browser/passwords/credential_manager.h

index d37d63ea11d171ea41926b8a48a3f8894b47c36b..876e7073ce45f24b1cafabc1770947770919fdf0 100644

--- a/ios/chrome/browser/passwords/credential_manager.h

+++ b/ios/chrome/browser/passwords/credential_manager.h

@@ -58,7 +58,7 @@ class CredentialManager

bool IsZeroClickAllowed() const override;

GURL GetOrigin() const override;

void SendCredential(

- int id,

+ const password_manager::SendCredentialCallback& send_callback,

const password_manager::CredentialInfo& credential) override;

password_manager::PasswordManagerClient* client() const override;

autofill::PasswordForm GetSynthesizedFormForOrigin() const override;

@@ -83,6 +83,9 @@ class CredentialManager

ERROR_TYPE_SECURITY_ERROR_UNTRUSTED_ORIGIN,

};

+ void SendCredentialByID(int request_id,

+ const password_manager::CredentialInfo& credential);

// Sends a message via |js_manager_| to resolve the JavaScript Promise

// associated with |request_id|. Invoked after a page-initiated credential

// event is acknowledged by the PasswordStore.