Switch components/password_manager code from IPC messages to Mojo.

components/password_manager/core/common/credential_manager_types.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_COMMON_CREDENTIAL_MANAGER_TYPES_H_
 #define COMPONENTS_PASSWORD_MANAGER_CORE_COMMON_CREDENTIAL_MANAGER_TYPES_H_
 
 #include <stddef.h>
 
+#include <ostream>
 #include <string>
 
 #include "base/compiler_specific.h"
 #include "base/strings/string16.h"
 #include "url/gurl.h"
 #include "url/origin.h"
 
 namespace autofill {
 struct PasswordForm;
 }
 
 namespace password_manager {
 
 // Limit the size of the federations array that we pass to the browser to
 // something reasonably sane.
 const size_t kMaxFederations = 50u;
 
 enum class CredentialType {
   CREDENTIAL_TYPE_EMPTY = 0,
   CREDENTIAL_TYPE_PASSWORD,
   CREDENTIAL_TYPE_FEDERATED,
   CREDENTIAL_TYPE_LAST = CREDENTIAL_TYPE_FEDERATED
 };
 
+inline std::ostream& operator<<(std::ostream& os, CredentialType value) {

[vabr (Chromium), 2016/03/14 15:40:26]

Please do not inline this, create a .cc file and put the definition there. The
style guide is clear on this:
http://dev.chromium.org/developers/coding-style#TOC-Inline-functions

[leonhsl(Using Gerrit), 2016/03/16 07:07:28]

Done. Moved the definition to credential_manager_types.cc. Thanks!

+  switch (value) {
+    case CredentialType::CREDENTIAL_TYPE_EMPTY:
+      return os << "CredentialType::CREDENTIAL_TYPE_EMPTY";
+    case CredentialType::CREDENTIAL_TYPE_PASSWORD:
+      return os << "CredentialType::CREDENTIAL_TYPE_PASSWORD";
+    case CredentialType::CREDENTIAL_TYPE_FEDERATED:
+      return os << "CredentialType::CREDENTIAL_TYPE_FEDERATED";
+    default:

[vabr (Chromium), 2016/03/14 15:40:26]

nit: Move this from the default clause to below line 46. This will again use the
compiler check in case somebody extends this enum. But I agree with your code
that there should not be a NOTREACHED anywhere in this method, because it is not
useful to crash in the middle of supplying info to another DCHECK.

[leonhsl(Using Gerrit), 2016/03/16 07:07:28]

Done.

+      return os << "Unknown CredentialType value: "
+                << static_cast<int32_t>(value);
+  }
+}
+
 struct CredentialInfo {
   CredentialInfo();
   CredentialInfo(const autofill::PasswordForm& form, CredentialType form_type);
   CredentialInfo(const CredentialInfo& other);
   ~CredentialInfo();
 
   bool operator==(const CredentialInfo& rhs) const;
 
   CredentialType type;
 
@@ skipping 18 matching lines @@
 
 // Create a new autofill::PasswordForm object based on |info|, valid in the
 // context of |origin|. Returns an empty scoped_ptr for CREDENTIAL_TYPE_EMPTY.
 scoped_ptr<autofill::PasswordForm> CreatePasswordFormFromCredentialInfo(
     const CredentialInfo& info,
     const GURL& origin);
 
 }  // namespace password_manager
 
 #endif  // COMPONENTS_PASSWORD_MANAGER_CORE_COMMON_CREDENTIAL_MANAGER_TYPES_H_