components/password_manager/content/renderer/DEPS - Issue 1762603002: Switch components/password_manager code from IPC messages to Mojo.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/password_manager/content/renderer/DEPS

Issue 1762603002: Switch components/password_manager code from IPC messages to Mojo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add browsertests. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/password_manager/content/browser/credential_manager_impl.h ('K') | « components/password_manager/content/renderer/BUILD.gn ('k') | components/password_manager/content/renderer/credential_manager_client.h » ('j') | components/password_manager/content/renderer/credential_manager_client_browsertest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+content/public/common",	2 "+content/public/common",

3 "+content/public/renderer",	3 "+content/public/renderer",

4 "+content/test",	4 "+content/test",

5 "+third_party/WebKit/public/platform",	5 "+third_party/WebKit/public/platform",

6 "+third_party/WebKit/public/web",	6 "+third_party/WebKit/public/web",

7 ]	7 ]

	8

	9 specific_include_rules = {
	vabr (Chromium) 2016/03/14 15:40:26 Why is this restricted only to tests? (I'm thinkin Why is this restricted only to tests? (I'm thinking of the situation when someone needs this dependency in the production code later, and will be unsure if it's OK to remove the test-only restriction. Unless there is a good reason, I suggest just adding the dependency unconditionally.) leonhsl(Using Gerrit) 2016/03/16 07:07:28 Done. Show quoted text On 2016/03/14 15:40:26, vabr (Chromium) wrote: > Why is this restricted only to tests? > (I'm thinking of the situation when someone needs this dependency in the > production code later, and will be unsure if it's OK to remove the test-only > restriction. Unless there is a good reason, I suggest just adding the dependency > unconditionally.) Done.
	10 '._[a-z]test\.cc': [

	11 "+content/common/mojo",

	12 "+mojo/public",

	13 ],

	14 }

OLD	NEW