Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1762533002: X87: [compiler] Introduce initial StrictEqualStub. (Closed)

Created:
4 years, 9 months ago by zhengxing.li
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [compiler] Introduce initial StrictEqualStub. port 4acb492e145b39700bbbc36ff0da5830de50f814 (r34423) original commit message: Initial version of a new StrictEqualStub written as TurboFan code stub, that implements the full strict equality comparison and is usable for both TurboFan and Ignition (and soon for the generic CompareIC case too). The stub is not fully optimized yet, i.e. we still go to the runtime for string comparisons, but that'll be addressed in a follow-up CL. BUG= Committed: https://crrev.com/c7c95673762f12fc03b493db098e0797af9b08cb Cr-Commit-Position: refs/heads/master@{#34454}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +12 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 9 months ago (2016-03-03 01:46:36 UTC) #2
Weiliang
lgtm
4 years, 9 months ago (2016-03-03 02:18:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762533002/1
4 years, 9 months ago (2016-03-03 02:20:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 03:19:05 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 03:20:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7c95673762f12fc03b493db098e0797af9b08cb
Cr-Commit-Position: refs/heads/master@{#34454}

Powered by Google App Engine
This is Rietveld 408576698