recipe_modules/bot_update/api.py - Issue 1762513002: Use gclient's git_cache setting in bot_update/api.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: recipe_modules/bot_update/api.py

Issue 1762513002: Use gclient's git_cache setting in bot_update/api.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: comment nit Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: recipe_modules/bot_update/api.py

diff --git a/recipe_modules/bot_update/api.py b/recipe_modules/bot_update/api.py

index ccd725efce2ca9b07bad69dd155b8421779cab9b..f62d8bf66229e4f9b5564c1664eb6c3eb8ca9f17 100644

--- a/recipe_modules/bot_update/api.py

+++ b/recipe_modules/bot_update/api.py

@@ -143,7 +143,6 @@ class BotUpdateApi(recipe_api.RecipeApi):

['--spec', spec_string],

['--root', root],

['--revision_mapping_file', self.m.json.input(rev_map)],

- ['--git-cache-dir', self.m.path['git_cache']],

# 3. How to find the patch, if any (issue/patchset/patch_url).

['--issue', issue],

@@ -158,6 +157,10 @@ class BotUpdateApi(recipe_api.RecipeApi):

# 4. Hookups to JSON output back into recipes.

['--output_json', self.m.json.output()],]

+ # Honor gclient module's setting for whether to use a git cache.

+ # See chromium_no_git_cache config in gclient/config.py.

+ if self.m.gclient.c.cache_dir:

+ flags.append(['--git-cache-dir', self.m.gclient.c.cache_dir])

martiniss 2016/03/03 21:10:23 instead of 'self.m.gclient.c.cache_dir', use 'cfg.

# Collect all fixed revisions to simulate them in the json output.

# Fixed revision are the explicit input revisions of bot_update.py, i.e.

« no previous file with comments | « no previous file | recipe_modules/bot_update/example.py » ('j') | no next file with comments »