Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1762503002: Add some docs about mojom (files/IDL). (Closed)

Created:
4 years, 9 months ago by viettrungluu
Modified:
4 years, 4 months ago
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add some docs about mojom (files/IDL). Only "1/3" done, but it's already a lot. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/7ac75cd786a9cbba79b2b073656f1c15f0226e9f

Patch Set 1 #

Total comments: 7

Patch Set 2 : review #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -8 lines) Patch
M docs/intro/intro.md View 1 chunk +2 lines, -1 line 0 comments Download
M docs/intro/message_pipes.md View 2 chunks +5 lines, -4 lines 2 comments Download
D docs/intro/mojom.md View 1 chunk +0 lines, -3 lines 0 comments Download
A docs/intro/mojom_idl.md View 1 1 chunk +137 lines, -0 lines 0 comments Download
A docs/intro/mojom_protocol.md View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
viettrungluu
4 years, 9 months ago (2016-03-03 00:33:21 UTC) #1
vardhan
lgtm w/ corrections https://codereview.chromium.org/1762503002/diff/1/docs/intro/mojom_idl.md File docs/intro/mojom_idl.md (right): https://codereview.chromium.org/1762503002/diff/1/docs/intro/mojom_idl.md#newcode22 docs/intro/mojom_idl.md:22: (which receives request messages and receives ...
4 years, 9 months ago (2016-03-03 00:55:38 UTC) #2
viettrungluu
Thanks. https://codereview.chromium.org/1762503002/diff/1/docs/intro/mojom_idl.md File docs/intro/mojom_idl.md (right): https://codereview.chromium.org/1762503002/diff/1/docs/intro/mojom_idl.md#newcode22 docs/intro/mojom_idl.md:22: (which receives request messages and receives response messages). ...
4 years, 9 months ago (2016-03-03 01:01:54 UTC) #3
viettrungluu
Committed patchset #2 (id:20001) manually as 7ac75cd786a9cbba79b2b073656f1c15f0226e9f (presubmit successful).
4 years, 9 months ago (2016-03-03 01:02:33 UTC) #5
rudominer
I pointed out a place where you missed a "the" https://codereview.chromium.org/1762503002/diff/1/docs/intro/mojom_idl.md File docs/intro/mojom_idl.md (right): https://codereview.chromium.org/1762503002/diff/1/docs/intro/mojom_idl.md#newcode59 ...
4 years, 9 months ago (2016-03-03 01:04:33 UTC) #7
viettrungluu
Thanks, will include the fix in the next CL. On 2016/03/03 01:04:33, rudominer wrote: > ...
4 years, 9 months ago (2016-03-03 17:34:37 UTC) #8
jln (very slow on Chromium)
https://codereview.chromium.org/1762503002/diff/20001/docs/intro/message_pipes.md File docs/intro/message_pipes.md (right): https://codereview.chromium.org/1762503002/diff/20001/docs/intro/message_pipes.md#newcode41 docs/intro/message_pipes.md:41: combined wait-then-read may form an asynchronous pattern.) didn't you ...
4 years, 4 months ago (2016-07-26 23:20:23 UTC) #10
vardhan
4 years, 4 months ago (2016-07-26 23:36:44 UTC) #11
Message was sent while issue was closed.
https://codereview.chromium.org/1762503002/diff/20001/docs/intro/message_pipe...
File docs/intro/message_pipes.md (right):

https://codereview.chromium.org/1762503002/diff/20001/docs/intro/message_pipe...
docs/intro/message_pipes.md:41: combined wait-then-read may form an asynchronous
pattern.)
On 2016/07/26 23:20:23, jln (very slow on Chromium) wrote:
> didn't you mean "may form a synchronous pattern" here?

yeah, i think synchronous pattern is right

Powered by Google App Engine
This is Rietveld 408576698