Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1762483003: X87: [turbofan] Introduce DeoptimizeIf And DeoptimizeUnless common operators. (Closed)

Created:
4 years, 9 months ago by zhengxing.li
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Introduce DeoptimizeIf And DeoptimizeUnless common operators. port c129aa4d39364bf78d93bec8c16811bfde040a37 (r34239) original commit message: These macro operators represent a conditional eager deoptimization exit without explicit branching, which greatly reduces overhead of both scheduling and register allocation, and thereby greatly reduces overall compilation time, esp. when there are a lot of eager deoptimization exits. BUG= Committed: https://crrev.com/e8df3439c8c22bb6b0748ce50b3cd557390b1703 Cr-Commit-Position: refs/heads/master@{#34453}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -24 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 2 chunks +38 lines, -2 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 12 chunks +63 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 9 months ago (2016-03-03 01:50:18 UTC) #2
Weiliang
lgtm
4 years, 9 months ago (2016-03-03 02:26:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762483003/1
4 years, 9 months ago (2016-03-03 02:29:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 02:47:43 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 02:49:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8df3439c8c22bb6b0748ce50b3cd557390b1703
Cr-Commit-Position: refs/heads/master@{#34453}

Powered by Google App Engine
This is Rietveld 408576698