Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 9 months ago by rune Modified:
4 years, 9 months ago Reviewers:
dstockwell CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAvoid nuking everything when injecting stylesheet.
Instead do an analyzed update of the Document scope.
Committed: https://crrev.com/6ddb19de461880fa47a5c563f30119e6d05b20be
Cr-Commit-Position: refs/heads/master@{#379528}
Patch Set 1 #
Created: 4 years, 9 months ago
Messages
Total messages: 17 (5 generated)
The CQ bit was checked by rune@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762443004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762443004/1
rune@opera.com changed reviewers: + dstockwell@chromium.org
ptal
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ping
lgtm
The CQ bit was checked by rune@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762443004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762443004/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Avoid nuking everything when injecting stylesheet. Instead do an analyzed update of the Document scope. ========== to ========== Avoid nuking everything when injecting stylesheet. Instead do an analyzed update of the Document scope. Committed: https://crrev.com/6ddb19de461880fa47a5c563f30119e6d05b20be Cr-Commit-Position: refs/heads/master@{#379528} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6ddb19de461880fa47a5c563f30119e6d05b20be Cr-Commit-Position: refs/heads/master@{#379528}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1770903002/ by treib@chromium.org. The reason for reverting is: Seems to have introduced a (slightly flaky) use-after-free on Mac ASan 64: https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests... "All_ParameterizedWebFrameTest.SetForceZeroLayoutHeightWorksAcrossNavigations_1" fails pretty consistently (only 1 success out of ~20 runs), a few others fail only occasionally..
Message was sent while issue was closed.
On 2016/03/07 17:43:43, Marc Treib wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/1770903002/ by mailto:treib@chromium.org. > > The reason for reverting is: Seems to have introduced a (slightly flaky) > use-after-free on Mac ASan 64: > https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests... > > "All_ParameterizedWebFrameTest.SetForceZeroLayoutHeightWorksAcrossNavigations_1" > fails pretty consistently (only 1 success out of ~20 runs), a few others fail > only occasionally.. Reverting this didn't help, and it looks unlikely that this was the cause. Can I re-land?
Message was sent while issue was closed.
On 2016/03/07 19:17:05, rune wrote: > On 2016/03/07 17:43:43, Marc Treib wrote: > > A revert of this CL (patchset #1 id:1) has been created in > > https://codereview.chromium.org/1770903002/ by mailto:treib@chromium.org. > > > > The reason for reverting is: Seems to have introduced a (slightly flaky) > > use-after-free on Mac ASan 64: > > > https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests... > > > > > "All_ParameterizedWebFrameTest.SetForceZeroLayoutHeightWorksAcrossNavigations_1" > > fails pretty consistently (only 1 success out of ~20 runs), a few others fail > > only occasionally.. > > Reverting this didn't help, and it looks unlikely that this was the cause. > > Can I re-land? Go for it, as you said the revert didn't seem to help.
Message was sent while issue was closed.
On 2016/03/07 22:46:22, benwells wrote: > On 2016/03/07 19:17:05, rune wrote: > > Can I re-land? > > Go for it, as you said the revert didn't seem to help. Already happened in https://codereview.chromium.org/1767163002/ |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
