Avoid nuking everything when injecting stylesheet.

Avoid nuking everything when injecting stylesheet.

Instead do an analyzed update of the Document scope.

Committed: https://crrev.com/6ddb19de461880fa47a5c563f30119e6d05b20be
Cr-Commit-Position: refs/heads/master@{#379528}

[rune, 2016-03-03 12:38:11]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-03 12:38:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1762443004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1762443004/1

[rune, 2016-03-03 13:22:17]

rune@opera.com changed reviewers:
+ dstockwell@chromium.org

[rune, 2016-03-03 13:22:18]

ptal

[commit-bot: I haz the power, 2016-03-03 13:46:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 13:46:10]

Dry run: This issue passed the CQ dry run.

[rune, 2016-03-06 20:25:12]

ping

[dstockwell, 2016-03-06 22:59:07]

lgtm

[rune, 2016-03-07 07:46:48]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-03-07 07:47:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1762443004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1762443004/1

[commit-bot: I haz the power, 2016-03-07 09:03:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-07 09:05:17]

Description was changed from

==========
Avoid nuking everything when injecting stylesheet.

Instead do an analyzed update of the Document scope.
==========

to

==========
Avoid nuking everything when injecting stylesheet.

Instead do an analyzed update of the Document scope.

Committed: https://crrev.com/6ddb19de461880fa47a5c563f30119e6d05b20be
Cr-Commit-Position: refs/heads/master@{#379528}
==========

[commit-bot: I haz the power, 2016-03-07 09:05:18]

Patchset 1 (id:??) landed as
https://crrev.com/6ddb19de461880fa47a5c563f30119e6d05b20be
Cr-Commit-Position: refs/heads/master@{#379528}

[Marc Treib, 2016-03-07 17:43:43]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1770903002/ by treib@chromium.org.

The reason for reverting is: Seems to have introduced a (slightly flaky)
use-after-free on Mac ASan 64:
https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests...

"All_ParameterizedWebFrameTest.SetForceZeroLayoutHeightWorksAcrossNavigations_1"
fails pretty consistently (only 1 success out of ~20 runs), a few others fail
only occasionally..

[rune, 2016-03-07 19:17:05]

On 2016/03/07 17:43:43, Marc Treib wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1770903002/ by mailto:treib@chromium.org.
> 
> The reason for reverting is: Seems to have introduced a (slightly flaky)
> use-after-free on Mac ASan 64:
>
https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests...
> 
>
"All_ParameterizedWebFrameTest.SetForceZeroLayoutHeightWorksAcrossNavigations_1"
> fails pretty consistently (only 1 success out of ~20 runs), a few others fail
> only occasionally..

Reverting this didn't help, and it looks unlikely that this was the cause.

Can I re-land?

[benwells, 2016-03-07 22:46:22]

On 2016/03/07 19:17:05, rune wrote:
> On 2016/03/07 17:43:43, Marc Treib wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/1770903002/ by mailto:treib@chromium.org.
> > 
> > The reason for reverting is: Seems to have introduced a (slightly flaky)
> > use-after-free on Mac ASan 64:
> >
>
https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests...
> > 
> >
>
"All_ParameterizedWebFrameTest.SetForceZeroLayoutHeightWorksAcrossNavigations_1"
> > fails pretty consistently (only 1 success out of ~20 runs), a few others
fail
> > only occasionally..
> 
> Reverting this didn't help, and it looks unlikely that this was the cause.
> 
> Can I re-land?

Go for it, as you said the revert didn't seem to help.

[rune, 2016-03-07 22:59:36]

On 2016/03/07 22:46:22, benwells wrote:
> On 2016/03/07 19:17:05, rune wrote:

> > Can I re-land?
> 
> Go for it, as you said the revert didn't seem to help.

Already happened in https://codereview.chromium.org/1767163002/