Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1762433002: [MD settings] remove override of the default font (Closed)

Created:
4 years, 9 months ago by dschuyler
Modified:
4 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] remove override of the default font The settings ui was explicitly setting the font to a 14px font rather than allowing the md setting css font settings through. This CL removes setting the 14px font. This makes the common font size 12px, but that will be addressed in a future CL to bring the font size to the desired 13px. BUG=589630 Committed: https://crrev.com/d6c3c59253fe0692e4e8dec8f6c9b7d65291e217 Cr-Commit-Position: refs/heads/master@{#378842}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/resources/settings/settings_ui/settings_ui.css View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dschuyler
4 years, 9 months ago (2016-03-02 20:29:25 UTC) #2
Dan Beam
lgtm
4 years, 9 months ago (2016-03-02 21:35:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762433002/1
4 years, 9 months ago (2016-03-02 21:42:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 21:47:50 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 21:49:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6c3c59253fe0692e4e8dec8f6c9b7d65291e217
Cr-Commit-Position: refs/heads/master@{#378842}

Powered by Google App Engine
This is Rietveld 408576698