Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 1762423002: Add UseCounters for various RegExp compatibility issues (Closed)

Created:
4 years, 9 months ago by Dan Ehrenberg
Modified:
4 years, 9 months ago
Reviewers:
yangguo, Yang
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add UseCounters for various RegExp compatibility issues We have compatibility workarounds to return 'undefined' on accessors to RegExp.prototype. This patch adds two UseCounters for two categories of this non-spec-compliant path: - source - ignorecase, multiline, global R=yangguo BUG=chromium:581577 LOG=Y Committed: https://crrev.com/4ea11ca941fc074fcbacace405ac684d20e34f61 Cr-Commit-Position: refs/heads/master@{#34597}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M include/v8.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/js/macros.py View 1 chunk +12 lines, -0 lines 0 comments Download
M src/js/regexp.js View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Dan Ehrenberg
4 years, 9 months ago (2016-03-04 22:33:29 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762423002/1
4 years, 9 months ago (2016-03-04 22:33:30 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-04 22:57:11 UTC) #5
Yang
On 2016/03/04 22:57:11, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 9 months ago (2016-03-07 06:59:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762423002/1
4 years, 9 months ago (2016-03-07 15:37:22 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_compile_dbg on tryserver.v8 (JOB_TIMED_OUT, no build URL)
4 years, 9 months ago (2016-03-07 17:37:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762423002/1
4 years, 9 months ago (2016-03-08 18:45:37 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 19:14:04 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 19:14:54 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ea11ca941fc074fcbacace405ac684d20e34f61
Cr-Commit-Position: refs/heads/master@{#34597}

Powered by Google App Engine
This is Rietveld 408576698