Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1762413002: Cleanup: remove prefix chrome_ of chrome/browser/media/chrome* files (Closed)

Created:
4 years, 9 months ago by mcasas
Modified:
4 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, phoglund+watch_chromium.org, posciak+watch_chromium.org, tnakamura+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: remove prefix chrome_ of chrome/browser/media/chrome* files Note how the name of the tests inside the files respect the new naming, and not the chrome_ prefixed. Done in two moves: $ for i in `ls chrome_*`; do git mv $i `echo $i | sed -e 's/chrome_//'`; done $ tools/git/mass-rename.py No new code whatsoever. BUG=592104 Committed: https://crrev.com/d8863236eda7fe4a3bfae3bbc39d10bbf7be2a30 Cr-Commit-Position: refs/heads/master@{#380662}

Patch Set 1 #

Patch Set 2 : reran the commands #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2632 lines) Patch
D chrome/browser/media/chrome_media_stream_infobar_browsertest.cc View 1 chunk +0 lines, -168 lines 0 comments Download
D chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc View 1 chunk +0 lines, -305 lines 0 comments Download
D chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc View 1 chunk +0 lines, -812 lines 0 comments Download
D chrome/browser/media/chrome_webrtc_browsertest.cc View 1 1 chunk +0 lines, -116 lines 0 comments Download
D chrome/browser/media/chrome_webrtc_disable_encryption_flag_browsertest.cc View 1 chunk +0 lines, -95 lines 0 comments Download
D chrome/browser/media/chrome_webrtc_getmediadevices_browsertest.cc View 1 chunk +0 lines, -295 lines 0 comments Download
D chrome/browser/media/chrome_webrtc_perf_browsertest.cc View 1 1 chunk +0 lines, -245 lines 0 comments Download
D chrome/browser/media/chrome_webrtc_simulcast_browsertest.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc View 1 1 chunk +0 lines, -394 lines 0 comments Download
D chrome/browser/media/chrome_webrtc_webcam_browsertest.cc View 1 chunk +0 lines, -121 lines 0 comments Download
A + chrome/browser/media/media_stream_infobar_browsertest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/media/webrtc_apprtc_browsertest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/media/webrtc_audio_quality_browsertest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/media/webrtc_browsertest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/media/webrtc_disable_encryption_flag_browsertest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/media/webrtc_getmediadevices_browsertest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/media/webrtc_perf_browsertest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/media/webrtc_simulcast_browsertest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/media/webrtc_video_quality_browsertest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/media/webrtc_webcam_browsertest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 8 chunks +25 lines, -25 lines 0 comments Download

Messages

Total messages: 38 (17 generated)
mcasas
phoglund@ PTAL/Owners RS
4 years, 9 months ago (2016-03-04 21:48:38 UTC) #3
phoglund_chromium
chrome_*_browsertest.cc used to be the convention for browser tests (as opposed to content browsertests, which ...
4 years, 9 months ago (2016-03-07 10:48:20 UTC) #5
mcasas
jam@ ping
4 years, 9 months ago (2016-03-08 21:36:04 UTC) #6
mcasas
On 2016/03/08 21:36:04, mcasas wrote: > jam@ ping jam@ ping
4 years, 9 months ago (2016-03-09 16:57:49 UTC) #7
mcasas
dalecurtis@ could you please answer phoglund@s micro question in #5 ? jam@ is unresponsive
4 years, 9 months ago (2016-03-10 17:37:44 UTC) #9
DaleCurtis
I can't speak for the chrome/ reviewers, so +thakis - My personal preference is to ...
4 years, 9 months ago (2016-03-10 17:47:23 UTC) #11
Nico
lgtm if you want to do this and chrome/browser/media people are onboard. I agree the ...
4 years, 9 months ago (2016-03-10 18:12:18 UTC) #12
mcasas
On 2016/03/10 18:12:18, Nico wrote: > lgtm if you want to do this and chrome/browser/media ...
4 years, 9 months ago (2016-03-10 18:35:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762413002/20001
4 years, 9 months ago (2016-03-10 19:41:02 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/128818)
4 years, 9 months ago (2016-03-10 20:58:07 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762413002/20001
4 years, 9 months ago (2016-03-10 21:21:58 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/128935)
4 years, 9 months ago (2016-03-10 22:33:13 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762413002/20001
4 years, 9 months ago (2016-03-10 23:12:44 UTC) #24
DaleCurtis
lgtm
4 years, 9 months ago (2016-03-10 23:21:15 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/129083)
4 years, 9 months ago (2016-03-11 00:21:05 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762413002/20001
4 years, 9 months ago (2016-03-11 01:05:14 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/129259)
4 years, 9 months ago (2016-03-11 02:10:40 UTC) #31
phoglund_chromium
Yeah, sounds like people are mostly onboard. Ship it lgtm
4 years, 9 months ago (2016-03-11 09:01:50 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762413002/20001
4 years, 9 months ago (2016-03-11 16:57:05 UTC) #34
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-11 17:36:09 UTC) #36
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 17:37:34 UTC) #38
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d8863236eda7fe4a3bfae3bbc39d10bbf7be2a30
Cr-Commit-Position: refs/heads/master@{#380662}

Powered by Google App Engine
This is Rietveld 408576698